added simple dependency provider #16
Conversation
stephanos
commented
Mar 2, 2014
stephanos
commented
- values can be created by factory
- factory is a simple function
- factory results are cached
- factory can depend on other factory
- dependency loop detection (plus detailed error description)
- values can be created by factory - factory is a simple function - factory results are cached - factory can depend on other factory - dependency loop detection (plus detailed error description)
|
Initial implementation for issue #10. |
| @@ -49,10 +49,11 @@ type TypeMapper interface { | |||
| Set(reflect.Type, reflect.Value) TypeMapper | |||
| // Returns the Value that is mapped to the current type. Returns a zeroed Value if | |||
| // the Type has not been mapped. | |||
| Get(reflect.Type) reflect.Value | |||
| Get(reflect.Type, ...bool) reflect.Value | |||
There was a problem hiding this comment.
Would it make more sense to have another method instead of passing a bool to the Get function?
There was a problem hiding this comment.
Well, off the top of my head: yes, it might. Maybe GetRoot(reflect.Type) reflect.Value.
There was a problem hiding this comment.
Was this a subtle hint for me to make this change? I can't handle subtle ;)
|
I'm going to sit on this for a bit. I'm not super sure about the implementation and I may need to dive into the code a bit more and get a feel for it |
|
Sure. That's what it's there for: getting the ball rollin' :) If you tell me your worries we could discuss it. |
|
@codegangsta I'll be working on it again this weekend. If you shared your concerns with the implementation I could improve it ... |
|
@codegangsta it seems you aren't really interested in working this out. So closing it now. If you change your mind, my fork can be found here: https://github.com/101loops/inject |
|
Apologies for the lack of response. We may revisit this in a later version but it adds a little too much complexity at the moment. Sent from my iPhone
|
