Skip to content

fix: remove option to use a custom config file via service #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

michalsn
Copy link
Member

Description
This PR removes the ability to define a custom config file for the queue (when using service()). From now on, configuration will rely exclusively on config('Queue'). If any changes are needed after publishing the config, they can be made manually or through a Registrar.

The queue worker didn’t work with custom config files, and supporting them introduced unnecessary complexity. Sticking to a single config file (similar to how Tasks are handled) offers a cleaner and more predictable approach.

Fixes #57

An alternative PR, which implements custom config file support: #58

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14516422233

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.011%

Totals Coverage Status
Change from base Build 14492436654: 0.0%
Covered Lines: 668
Relevant Lines: 726

💛 - Coveralls

@michalsn michalsn merged commit 39f0a8b into codeigniter4:develop May 5, 2025
19 checks passed
@michalsn
Copy link
Member Author

michalsn commented May 5, 2025

Thank you @samsonasik ans @paulbalandan

@michalsn michalsn deleted the one-config branch May 28, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Queue Service with Custom Configuration File
4 participants