Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions faq/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Document</title>
</head>
<body>
faq
</body>
</html>
Binary file added images/Img_home_01.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Property 1=sm.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/ic_facebook.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

벡터 이미지는 svg로 저장하시는걸 추천드려요 !

이하 MDN
SVG(Scalable Vector Graphics)는 2차원 벡터 그래픽을 서술하는 XML 기반의 마크업 언어입니다. SVG는 텍스트 기반의 열린 웹 표준 중 하나로, 모든 사이즈에서 깔끔하게 렌더링 되는 이미지를 서술하며 CSS, DOM, JavaScript, SMIL (en-US) 등 다른 웹 표준과도 잘 동작하도록 설계됐습니다. SVG는 달리 말하자면 HTML과 텍스트의 관계를 그래픽에 적용한 것입니다

image

이미지 파일은 최소 단위가 픽셀로 되어있으며 확대했을 때 이미지가 깨질 수 있어요 !
피그마에서 export하실 때에 svgexport할 수 있습니다 😊

Rester vs Vector

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 png가 아닌 svg로 export 하겠습니다

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/ic_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/ic_twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/ic_youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
113 changes: 113 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>판다마켓</title>
</head>
<body>
<header>
<div class="header-container">
<a href="/"><img src="/images/Property 1=sm.png" /></a>
<a class="login-button" href="/login/">로그인</a>
</div>
</header>
<main>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

훌륭합니다 ! 문서의 핵심이 되는 곳에 main을 적절히 넣으셨군요 👍

그냥 놓칠 수도 있었을텐데, 훌륭합니다 👍👍

<section class="section1">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

크으 ~ 시맨틱을 고려하셨군요 !

div로 하고 넘어갈 수도 있었을텐데, section으로 작성하셨군요 👍👍

<div class="section1-container">
<div class="section1-content">
<h2>
일상의 모든 물건을 <br />
거래해 보세요
</h2>
<a href="/items/">구경하러 가기</a>
</div>
<img src="/images/Img_home_top.png" />
</div>
</section>
<section class="section2">
<div class="section2-container">
<img src="/images/Img_home_01.png" />
<div class="section2-content">
<h3>Hot item</h3>
<h2>
인기 상품을<br />
확인해 보세요
</h2>
Comment on lines +33 to +37
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h 태그는 순차적으로 기입하는 것을 권장드립니다 !

h1 다음은 h2. 그리고 h3...
이런식으로 순차적으로 기입할 것을 MDN에서 권장하고 있습니다. 😊

MDN: 제목 단계를 건너뛰는 것을 피하세요. 언제나 <h1>로 시작해서, <h2>, 순차적으로 기입하세요.

<p>
가장 HOT한 중고거래 물품을<br />
판다 마켓에서 확인해 보세요
</p>
</div>
</div>
</section>
<section class="section3">
<div class="section3-container">
<div class="section3-content">
<h3>Search</h3>
<h2>
구매를 원하는<br />
상품을 검색하세요
</h2>
<p>
구매하고 싶은 물품은 검색해서<br />
쉽게 찾아보세요
</p>
</div>
<img src="/images/Img_home_02.png" />
</div>
</section>
<section class="section4">
<div class="section4-container">
<img src="/images/Img_home_03.png" />
<div class="section4-content">
<h3>Register</h3>
<h2>
판매를 원하는<br />
상품을 등록하세요
</h2>
<p>
어떤 물건이든 판매하고 싶은 상품을<br />
쉽게 등록하세요
</p>
</div>
</div>
</section>
<section class="section5">
<div class="section5-container">
<div class="section5-content">
<h2>
믿을 수 있는 <br />
판다마켓 중고 거래
</h2>
</div>
<img src="/images/Img_home_bottom.png" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt를 작성해볼까요?

alt는 스크린 리더 사용자에 대한 보조 텍스트가 될 수 있으므로 "어떠한 이미지 인지"를 작성해주는 것이 좋아요 !

alt의 목적

  • 인터넷 연결이 끊겼을 때 대체되는 이미지
  • 스크린 리더 사용자를 위한 대체 텍스트
  • 이미지를 볼 수 없는 환경에서 이미지를 대체하기 위한 텍스트
    등 목적을 알게 된다면 alt를 어떻게 사용하시면 될지 알 수 있을 것 같아요.

다음은 하버드 에듀케이션에서 제안하는 alt 규칙입니다:

tl;dr

  • Write Good Alt Text
  • Add alt text all non-decorative images.
  • Keep it short and descriptive, like a tweet.
  • Don’t include “image of” or “photo of”.
  • Leave alt text blank if the image is purely decorative
  • It's not necessary to add text in the Title field.

원문 보기

</div>
</section>
<footer>
<div class="footer-container">
<span>©codeit - 2024</span>
<div class="footer-container-center">
<a href="/privacy">Privacy Policy</a>
<a href="/faq">FAQ</a>
</div>
<div class="footer-container-end">
<a href="https://www.facebook.com/?locale=ko_KR" target="_blank"
><img src="/images/ic_facebook.png"
/></a>
<a href="https://x.com/?lang=ko" target="_blank"
><img src="/images/ic_twitter.png"
/></a>
<a href="https://www.youtube.com/" target="_blank"
><img src="/images/ic_youtube.png"
/></a>
<a href="https://www.instagram.com/" target="_blank"
><img src="/images/ic_instagram.png"
/></a>
</div>
Comment on lines +95 to +108
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(제안/선택)요소들이 순서 없는 목록을 의미한다면 <ul><li>로도 나타낼 수 있습니다 !

<ul class="footer-social">
  <li>
	<a target="_blank" href="https://www.facebook.com/">
	  <img src="images/ic_facebook.svg" alt="페이스북" />
	</a>
  </li>
  <li>
	<a target="_blank" href="https://www.twitter.com/">
	  <img src="images/ic_twitter.svg" alt="트위터" />
	</a>
  </li>
  <li>
	<a target="_blank" href="https://www.youtube.com/">
	  <img src="images/ic_youtube.svg" alt="유튜브" />
	</a>
  </li>
  <li>
	<a target="_blank" href="https://www.instagram.com/">
	  <img src="images/ic_instagram.svg" alt="인스타그램" />
	</a>
  <li>
</ul>

MDN: HTML <ul> 요소는 정렬되지 않은 목록을 나타냅니다. 보통 불릿으로 표현합니다.

li 태그의 기본 스타일을 제거하고 싶다면 다음과 같이 작성할 수 있습니다 ! { list-style: none; }

</div>
</footer>
</main>
</body>
</html>
11 changes: 11 additions & 0 deletions items/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Document</title>
</head>
<body>
items
</body>
</html>
11 changes: 11 additions & 0 deletions login/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Document</title>
</head>
<body>
login
</body>
</html>
11 changes: 11 additions & 0 deletions privacy/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Document</title>
</head>
<body>
Privacy
</body>
</html>
226 changes: 226 additions & 0 deletions style.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,226 @@
* {
box-sizing: border-box;
}

body {
font-family: Pretendard;
margin: 0;
}

header {
position: fixed;
top: 0;
left: 0;
width: 100%;
z-index: 100;
display: flex;
algin-items: center;
background: #ffffff;
}

.header-container {
display: flex;
justify-content: space-between;
align-items: center;
margin: 0 auto;
width: 100%;
padding: 10px 400px;
height: 70px;
}

.header-container > img {
flex-shrink: 0;
}

.login-button {
flex-shrink: 0;
padding: 12px 23px;
border-radius: 8px;
background: #3692ff;
color: #f3f4f6;
cursor: pointer;
border: none;
}

body {
background: #ffffff;
color: #374151;
}

.section1 {
background: #cfe5ff;
margin-top: 70px;
}

.section1-container {
display: flex;
justify-content: center;
flex-shrink: 0;
padding-top: 200px;
margin: 0 auto;
max-width: 1200px;
}

.section1-container > img {
width: 746px;
height: 340px;
}

.section1-content {
padding: 30px 0;
}

h2 {
font-weight: 700;
font-size: 40px;
line-height: 140%;
color: #374151;
}

.section1-content > a {
display: flex;
background: #3692ff;
padding: 16px 124px;
border: none;
border-radius: 40px;
font-weight: 600;
font-size: 20px;
line-height: 32px;
color: #f9fafb;
cursor: pointer;
}

.section2 {
margin: 0 auto;
padding: 140px 0;
}

.section2-container {
background: #fcfcfc;
display: flex;
justify-content: center;
max-width: 1000px;
margin: 0 auto;
position: relative;
gap: 50px;
}

.section2-content {
margin: 60px 10px 60px 0;
}

h3 {
font-weight: 800;
font-family: Abhaya Libre ExtraBold;
font-size: 18px;
line-height: 26px;
color: #3692ff;
}

p {
font-weight: 500;
font-size: 24px;
line-height: 32px;
}

.section3 {
margin: 0 auto;
padding: 140px 0;
}

.section3-container {
background: #fcfcfc;
display: flex;
justify-content: center;
max-width: 1000px;
margin: 0 auto;
position: relative;
gap: 50px;
}

.section3-content {
margin: 60px 10px 60px 0;
text-align: right;
}
.section4 {
margin: 0 auto;
padding: 140px 0;
}

.section4-container {
background: #fcfcfc;
display: flex;
justify-content: center;
max-width: 1000px;
margin: 0 auto;
position: relative;
gap: 50px;
}
.section4-content {
margin: 60px 0;
}

.section5 {
background: #cfe5ff;
margin-top: 70px;
}

.section5-container {
display: flex;
justify-content: center;
flex-shrink: 0;
padding-top: 200px;
margin: 0 auto;
max-width: 1200px;
}

.section5-container > img {
width: 746px;
height: 340px;
}

.section5-content {
padding: 30px 0;
}

footer {
background: #111827;
height: 160px;
padding-top: 20px;
}

.footer-container {
display: flex;
justify-content: space-between;
algin-items: center;
max-width: 1000px;
margin: 0 auto;
}

.footer-container > span {
font-weight: 400;
font-size: 16px;
line-height: 100%;
color: #9ca3af;
}

.footer-container-center {
display: flex;
justify-content: space-between;
gap: 20px;
color: #e5e7eb;
font-size: 16px;
line-height: 100%;
font-weight: 400;
}

a {
text-decoration: none;
color: inherit;
}

.footer-container-end {
display: flex;
justify-content: space-between;
gap: 10px;
}