Skip to content

Conversation

quintesse
Copy link
Contributor

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for defining additional Maven repositories in jpm, enabling users to resolve artifacts from custom repositories beyond Maven Central. The implementation includes both CLI options and app.yml configuration file support for repositories.

Key Changes

  • Added support for defining additional repositories via CLI options (-r, --repo)
  • Extended app.yml configuration to include a repositories section
  • Refactored artifact resolution to accept and use custom repositories

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/main/java/org/codejive/jpm/config/AppInfo.java Moved from json package, added repositories field and parsing/writing logic
src/main/java/org/codejive/jpm/util/Resolver.java Added repository parameter support and repository parsing functionality
src/main/java/org/codejive/jpm/Main.java Added CLI repository options and updated method calls to pass repository information
src/main/java/org/codejive/jpm/Jpm.java Updated package import and added repository support to copy, install, and path operations
src/test/java/org/codejive/jpm/config/AppInfoTest.java Updated package declaration to match moved AppInfo class

@quintesse quintesse marked this pull request as draft August 29, 2025 16:48
@quintesse
Copy link
Contributor Author

@copilot create unit tests for the new repositories feature. This should include both tests for repos defined in the app.yml file as well as repos passed to the cli commands and situations where both are used.

@quintesse quintesse marked this pull request as ready for review August 29, 2025 17:28
@quintesse quintesse merged commit 8e65772 into main Aug 29, 2025
2 checks passed
@quintesse quintesse deleted the repos branch August 29, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants