Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suport for Ruby 3.2 and remove Rails 5.* #80

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/rspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,18 @@ jobs:

runs-on: ubuntu-latest

strategy:
matrix:
# NOTE: appraisal 2.* doesn't work with Ruby 3.2. It should be added once this issue is resolved:
# https://github.com/thoughtbot/appraisal/issues/204
ruby-version: ['3.1', '3.0', '2.7']

steps:
- uses: actions/checkout@v3
- name: Set up Ruby
- name: Set up Ruby ${{ matrix.ruby-version }}
uses: ruby/setup-ruby@ec02537da5712d66d4d50a0f33b7eb52773b5ed1
with:
ruby-version: '3.1'
ruby-version: ${{ matrix.ruby-version }}
- name: Install dependencies
run: bundle install
- name: Installing all gem versions via Appraisal
Expand Down
3 changes: 3 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
AllCops:
TargetRubyVersion: 2.7

Metrics/ParameterLists:
Enabled: false
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.1.2
3.1.4
1 change: 1 addition & 0 deletions .tool-versions
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ruby 3.1.4
12 changes: 0 additions & 12 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,15 +1,3 @@
appraise "rails-5.0" do
gem "railties", "~>5.0.0"
end

appraise "rails-5.1" do
gem "railties", "~>5.1.0"
end

appraise "rails-5.2" do
gem "railties", "~>5.2.0"
end

appraise "rails-6.0" do
gem "railties", "~>6.0.0"
end
Expand Down
11 changes: 7 additions & 4 deletions cache_crispies.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,21 @@ Gem::Specification.new do |spec|
spec.summary = 'Fast Rails serializer with built-in caching'
spec.homepage = 'https://github.com/codenoble/cache-crispies'
spec.licenses = ['MIT']
spec.metadata = { 'source_code_uri' => 'https://github.com/example/example' }

spec.files = Dir.glob('{lib,spec}/**/*') + ['.rspec']
spec.test_files = spec.files.grep(%r{^(spec)/})
spec.require_paths = ['lib']

spec.add_dependency 'railties', '>= 5.0.0', '< 8.0'
spec.required_ruby_version = '>= 2.7.0'

spec.add_dependency 'railties', '>= 6.0.0', '< 8.0'
spec.add_dependency 'oj', '~> 3.7'

spec.add_development_dependency 'activemodel', '>= 5.0.0', '< 8.0'
spec.add_development_dependency 'appraisal', '~> 2.2'
spec.add_development_dependency 'activemodel', '>= 6.0.0', '< 8.0'
spec.add_development_dependency 'appraisal', '~> 2.4'
spec.add_development_dependency 'bundler', '~> 2.0'
spec.add_development_dependency 'byebug', '~> 11.0'
spec.add_development_dependency 'debug', '~> 1.8'
spec.add_development_dependency 'rspec', '~> 3.12.0'
spec.add_development_dependency 'rspec_junit_formatter', '~> 0.4'
spec.add_development_dependency 'simplecov', '~> 0.22'
Expand Down
7 changes: 0 additions & 7 deletions gemfiles/rails_5.0.gemfile

This file was deleted.

7 changes: 0 additions & 7 deletions gemfiles/rails_5.1.gemfile

This file was deleted.

7 changes: 0 additions & 7 deletions gemfiles/rails_5.2.gemfile

This file was deleted.

1 change: 0 additions & 1 deletion spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
)
end

require 'byebug'
require_relative '../lib/cache_crispies'

RSpec.configure do |config|
Expand Down