Update custom Navbar/Footer models & templatetags to work in multi-site #684
Conversation
coderedcms/project_template/pro/website/migrations/0003_footer_site_navbar_site.py
Outdated
Show resolved
Hide resolved
|
Nice work, thanks! We can remove that fallback code as it is not necessary and should simplify it a bit. Tests aren't necessary here, as long as you manually tested it. The pipeline will generate a pro project and run the full battery of tests using it. |
|
As requested. Also, apologies for committing directly to main vice a new branch. I'm clearly a bit out of practice 😬 |
There was a problem hiding this comment.
Please restore this file - it is needed in the project template.
| @@ -221,9 +221,17 @@ class Meta: | |||
| ], | |||
| use_json_field=True, | |||
| ) | |||
| site = models.ForeignKey( | |||
| "wagtailcore.Site", | |||
| on_delete=models.CASCADE, | |||
There was a problem hiding this comment.
I think SET_NULL would be preferable, in the event that you wanted to switch this navbar to a different site and deleted the site first. Similar to how the root page works.
| @@ -249,9 +257,17 @@ class Meta: | |||
| blank=True, | |||
| use_json_field=True, | |||
| ) | |||
| site = models.ForeignKey( | |||
| "wagtailcore.Site", | |||
| on_delete=models.CASCADE, | |||
|
Looking good, left a few more comments. I think it will be ready to merge after that. |
Description of change
Added a
siteFK field to the customNavbarandFootermodels in the pro template; added the new migration for these models; and updated the website templatetags in the pro template to work with the newly updated models.Resolves #683 & #673
Documentation
Updated the docs the discuss how the snippets in the basic and pro templates work with multi-site installs in different ways.
Tests
Did not add tests, because there are no existing tests for the pro template website app (unless I missed something). Without an existing test suite for the website app in which to add my tests, I didn't want to make significant additions without asking the coderedcorp folks how/if I should approach this.