Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubectl binary #52

Merged
merged 5 commits into from
Dec 19, 2017
Merged

Kubectl binary #52

merged 5 commits into from
Dec 19, 2017

Conversation

drewkit
Copy link
Contributor

@drewkit drewkit commented Dec 19, 2017

No description provided.

@drewkit drewkit requested a review from mlocher December 19, 2017 16:46
mlocher
mlocher suggested changes Dec 19, 2017
View reviewed changes
Copy link
Contributor

@mlocher mlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes, I'll also see if we already have access to EKS to add tests.

In any case we should add a step to print kubectl version or something similar.

deployment/Dockerfile Outdated
@@ -6,6 +6,12 @@ RUN \
bash \
curl \
jq \
zip
zip \
sudo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need sudo, since we don't switch off the root user for those images.

deployment/Dockerfile Outdated
sudo

# https://kubernetes.io/docs/tasks/tools/install-kubectl/#install-kubectl-binary-via-curl
ARG KUBECTL_VERSION="v1.8.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current version of kubectl is already 1.9.0

mlocher
mlocher approved these changes Dec 19, 2017
View reviewed changes
Copy link
Contributor

@mlocher mlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@drewkit drewkit merged commit abc9f05 into master Dec 19, 2017
@drewkit drewkit deleted the kubectl-binary branch December 19, 2017 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlocher mlocher mlocher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewkit @mlocher