chore(marketplace): use canMarkProofAsMissing #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2-towns
force-pushed
the
chore/fix-mark-proof-as-missing
branch
from
9a0e19c to
fe51f53
Compare
emizzle
approved these changes
Apr 17, 2025
Comment on lines
+208
to
+209
| test "can check whether a proof cannot be marked as missing before a proof is required": | ||
| let slotId = slotId(request, slotIndex) |
There was a problem hiding this comment.
Considering that each test starts off at the exact same point and assuming that the block hashes will always be deterministic, this test SHOULD work every time, but there may be a chance that there is a proof required as soon as the slot is filled.
| check (await market.canProofBeMarkedAsMissing(slotId, missingPeriod)) == true | ||
| check (await market.canMarkProofAsMissing(slotId, missingPeriod)) == true | ||
|
|
||
| test "can check whether a proof cannot be marked as missing when the slot is free": |
There was a problem hiding this comment.
Maybe we should add a test that checks if a proof is required before the slot is filled (also free)
There was a problem hiding this comment.
I'm not sure it's really useful, because if a slot isn't filled, we are not able to call waitUntilProofRequired which is almost the same situation as in the test "can check whether a proof cannot be marked as missing before a proof is required", no ?
2-towns
force-pushed
the
chore/fix-mark-proof-as-missing
branch
from
fe51f53 to
909d801
Compare
benbierens
approved these changes
Apr 18, 2025
Merged
2-towns
force-pushed
the
chore/fix-mark-proof-as-missing
branch
from
909d801 to
3634d86
Compare
2-towns
force-pushed
the
chore/fix-mark-proof-as-missing
branch
from
3634d86 to
f34a12a
Compare
2-towns
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1153 by using a new function in the contract, canProofBeMarkedAsMissing.
Since this function is a view and does not transfer reward funds to the validator, we should no longer encounter the ERC20: transfer to the zero address error.