Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #2613 #2670

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix issue #2613 #2670

wants to merge 1 commit into from

Conversation

egg-
Copy link

@egg- egg- commented Mar 29, 2024

Fix issue #2613

Changes:

  • Add exception code to prevent adding blocks when in read-only mode.

Please Checks:

neSpecc
neSpecc reviewed Jan 29, 2025
View reviewed changes
Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please, add a line to the changelog. And add a corresponded test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc left review comments

@gohabereg gohabereg Awaiting requested review from gohabereg gohabereg is a code owner

@TatianaFomina TatianaFomina Awaiting requested review from TatianaFomina TatianaFomina is a code owner

@ilyamore88 ilyamore88 Awaiting requested review from ilyamore88 ilyamore88 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
almost done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egg- @neSpecc