Skip to content

Keyboard event-related fixes + notifications improvements #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Keyboard event-related fixes + notifications improvements #1826

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
865abb2
moved _codidactKeyboard to QPixel.Keyboard & linter the file
Oaphi Sep 12, 2025
9abf8e0
fixed Ctrl+click on a notification item closing the inbox
Oaphi Sep 12, 2025
5fd3ff0
character count event handler should consider threshold warning a val…
Oaphi Sep 12, 2025
c371541
moved getModifierState to QPixel.DOM
Oaphi Sep 12, 2025
4c9add4
ensured cmd+click is properly handled for MacOS
Oaphi Sep 12, 2025
aa834f8
Merge branch 'develop' into 0valt/keyboard
Oaphi Sep 14, 2025
ccb09c3
Merge branch 'develop' into 0valt/keyboard
Oaphi Oct 7, 2025
ab05b9c
ensured user inbox is accessible even if JS is disabled
Oaphi Oct 7, 2025
2a5a639
minor cleanup of notifications controller
Oaphi Oct 7, 2025
b9f4276
allowed inbox notifications to be filtered by status
Oaphi Oct 7, 2025
b3ca34f
added sorting to full user inbox
Oaphi Oct 7, 2025
4f73b3c
added indication that a given notification is read or not (full inbox…
Oaphi Oct 7, 2025
2c3433e
Merge branch 'develop' into 0valt/keyboard
Oaphi Oct 12, 2025
d08bae9
Merge branch 'develop' into 0valt/keyboard
Oaphi Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/assets/javascripts/character_count.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ $(() => {
} else if (gteThreshold) {
setCounterState($counter, 'warning');
setCounterIcon($icon, 'fa-exclamation-circle');
setInputValidationState($tgt, 'valid');
} else {
setCounterState($counter, 'default');
setCounterIcon($icon, 'fa-check');
Expand Down
12 changes: 6 additions & 6 deletions app/assets/javascripts/comments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,14 @@ $(() => {
window.hljs && hljs.highlightAll();
}

$(document).on('click', '.post--comments-thread.is-inline a', async (evt) => {
if (evt.ctrlKey) {
return; // TODO: do we need this early exit?
$(document).on('click', '.post--comments-thread.is-inline a', async (ev) => {
if (ev.ctrlKey) {
return;
}

evt.preventDefault();
ev.preventDefault();

const $tgt = $(evt.target);
const $tgt = $(ev.target);
const $threadId = $tgt.data('thread');
const wrapper = getCommentThreadWrapper($tgt);

Expand All @@ -58,7 +58,7 @@ $(() => {
$(document).on('click', '.js-show-deleted-comments', (ev) => {
if (ev.ctrlKey) {
return;
} // do we really need it?
}

ev.preventDefault();

Expand Down
Loading