Drop Prometheus middleware from dramatiq settings #234
Conversation
Prometheus client became optional in dramatiq: https://github.com/Bogdanp/dramatiq/releases/tag/v2.0.0 I think we don't need to cover all our dependencies's subdependencies, so it is fine to drop it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 494 494
=========================================
Hits 494 494
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the optional Prometheus middleware from the dramatiq broker configuration in test settings, following dramatiq v2.0.0's change that made Prometheus client an optional dependency.
Key Changes
- Removed
dramatiq.middleware.Prometheusfrom the DRAMATIQ_BROKER middleware list
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 participants
Prometheus client became optional in dramatiq:
https://github.com/Bogdanp/dramatiq/releases/tag/v2.0.0
I think we don't need to cover all our dependencies's subdependencies, so it is fine to drop it.