Improve compatibility with other messagepack implementations, macro/functions for binary, no nightly #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`maybe_uninit_uninit_array` isn't needed anymore, since it's directly replaceable with an inline const expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy,
your library here is great, but I noticed a couple things when using it.
deriveand added a binary_unpack_iterOverall, I'm not sure you're going to want these changes. It makes the library much slower, but personally I'm much more interested in compatibility with other libraries/tools, and also not using the nightly toolchain.
I figured I'd bubble this up and see if you wanted any of these changes. (This also includes @tehmatt PR #16 )
If there's no interest in upstreaming, I will probably push up a fork of this to crates.io in a few weeks