feat: send upvote / downvote without reason #589
Conversation
| variables: { | ||
| articleId: articleReply.articleId, | ||
| replyId: articleReply.replyId, | ||
| vote: value, |
There was a problem hiding this comment.
This will cause issue in the following user sequence:
- The user clicks upvote, fills in some reason and then send
- The user clicks upvote again to open popup
- The user tries to dismiss the popup
We expect that the user's reason in step 1 should be preserved. However, the current implementation will wipe the reason entirely.
We may argue that the existing feedback button does not load the reason either. However, in this PR, it makes it easier for the user to clear the reason by accident.
I suggest we try amending the reason loading logic before accepting this change.
There was a problem hiding this comment.
So, if I understand correctly, we want to preserve the user submitted reason when they open the popup?
And optionally create a reply feedback on upvote / downvote with the existing reason if it exists?
There was a problem hiding this comment.
Yes -- if we want to submit feedback when popup is opened, it would be great if the reason is preserved. If the user want to change their reason after popup is opened, it's easier for them when the popup is already populated with existing reason.
fix #294
As in the issue description, I have changed to submit the feedback on every upvote / downvote click. The reason dialog stays the same, and it shows
Closewhen there is no input text,Sendotherwise.