Feature/openai #160
Open
Feature/openai #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrOrz
approved these changes
Feb 3, 2025
| @@ -15,16 +13,39 @@ const langfuse = new Langfuse({ | |||
| enabled: true, // set to false to disable sending events | |||
| }); | |||
|
|
|||
| const modelName = 'gemini-1.5-flash'; | |||
There was a problem hiding this comment.
我後來發現 gemini-1.5-flash 會預設是 gemini-1.5-flash-001
換成 gemini-1.5-flash-002 (gemini-1.5-flash-latest) 或 gemini-1.5-pro-002 (gemini-1.5-pro-latest) 的話，至少在逐字稿方面有顯著的進步
gemini-2.0-flash-exp 則是又快又準，但有很嚴格的 RPM quota
nonumpa
force-pushed
the
feature/openai
branch
from
6d7f154 to
5581765
Compare
MrOrz
reviewed
Feb 3, 2025
| ]); | ||
| for (const item of list) delete item.reason; | ||
| const sortedData = list.sort((a, b) => a.id.localeCompare(b.id)); | ||
| expect(sortedData).toMatchInlineSnapshot(` |
There was a problem hiding this comment.
nit: can just snapshot sortedData.map(({id}) => id)
| user: { id: 'tM9Gd4oBrkRFoI6raPG9', name: 'Zona' }, | ||
| }; | ||
|
|
||
| export const normalReply4 = { |
There was a problem hiding this comment.
can put unused fixtures in Langfuse dataset instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use OpenAI to replace Gemini for better spam detection result