Use threads_per_worker=-1 for Coiled Functions
#38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I propose that we hold off on this. The risk-reward don't seem worth it to
me (someone will be using an old install)
…On Thu, Oct 5, 2023 at 9:49 AM review-notebook-app[bot] < ***@***.***> wrote:
Check out this pull request on [image: ReviewNB]
<https://app.reviewnb.com/coiled/examples/pull/38>
See visual diffs & provide feedback on Jupyter Notebooks.
------------------------------
*Powered by ReviewNB <https://www.reviewnb.com/?utm_source=gh>*
—
Reply to this email directly, view it on GitHub
<#38 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKZTAKJH4DGQOVCVUNVDDX53CJDAVCNFSM6AAAAAA5UMTPD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBZGA3DIMZYHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
<https://coiled.io>
Matthew Rocklin CEO, Dask Maintainer
|
|
Makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a minor nit. Note it requires the latest
coiled=0.9.36release (pushed out about an hour ago)