-
Notifications
You must be signed in to change notification settings - Fork 433
feat/near chain signatures support #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat/near chain signatures support #562
Conversation
🟡 Heimdall Review Status
|
53a5467
to
47e1901
Compare
47e1901
to
a0e0917
Compare
hey @murrlincoln, any comments on this PR? Thanks |
typescript/agentkit/src/action-providers/near/nearActionProvider.ts
Outdated
Show resolved
Hide resolved
typescript/agentkit/src/wallet-providers/nearKeypairWalletProvider.ts
Outdated
Show resolved
Hide resolved
@CarsonRoscoe let me know what are your thoughts. Best |
@CarsonRoscoe @murrlincoln I would like to ask you what is the criteria to merge and review PRs. Considering more recent PRs like #665 was merged before this one. In general this PR has been open since March 13, that means after 36 days we are still here waiting and I have applied all your changes and suggestions. No more changes have been required from our side. If there are doubts or suggestions I'm happy to jump on a call and discuss about it. On the other hand, if the PR is not up to your coding standards or is not welcome you can also let me know. Because I have been constantly rebasing and merging and there is not clarity with it. I mean not even the pipeline has run. |
@CarsonRoscoe @murrlincoln Is this really the way to treat contributors? |
@CarsonRoscoe @murrlincoln any updates? |
any updates on this? @CarsonRoscoe @murrlincoln |
1 similar comment
any updates on this? @CarsonRoscoe @murrlincoln |
Description
This PR adds support for the NEAR protocol chain signatures, that allows a NEAR protocol account to control other accounts/addresses across multiple chains.
In order to enable the chain signatures support a NearKeyPairWalletProvider was required.
The PR also includes an example bot.
The following actions contain the functionality of the NEAR protocol chain signatures:
Tests
Sign payload
Get cross chain public key
Checklist
A couple of things to include in your PR for completeness: