-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add across action provider (ts) #566
base: main
Are you sure you want to change the base?
Conversation
🟡 Heimdall Review Status
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one comment around manual txn simulation and executing the deposit txn.
overall, really good job from an Across Protocol integration POV
} | ||
|
||
// Simulate the deposit transaction | ||
const { request } = await acrossClient.simulateDepositTx({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diving deep into the logic behind this, are we simulating txn and executing the deposit fn manually because there's no way to trigger a wallet extension ?
I ask because we have the executeQuote function which will be able to wrap complexities around txn simulation and executing the deposit txn.
overall this is a stellar job. thank you for putting in the effort here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @KanishkKhurana , thank you for the feedback!
I initially used executeQuote which would indeed simplify the process. This works fine until progress.step === "deposit" is succesful but then throws errors in the progress.step === "fill" step. I suspect this is because no RPC was available for the destination chain.
Now thinking about it again, it might work when we just add the destination chain to the viem client. It would certainly be nice to also return the fill txHash. A bit busy atm but will give it a try in the next days and get back to you
Description
Adds new action provider to perform cross-chain interactions via the Across protocol.
Across SDK is added as new dependency.
Implements bridge_token action to bridge from connected chain to another evm chain.
Supports native ETH and ERC-20 transfers (as long as supported by Across)
Tests
Checklist