feat: WalletAdvanced docs #1819
Conversation
github-actions
bot
added
documentation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| ## `WalletAdvancedContextType` | ||
|
|
||
| ```ts | ||
| export type WalletAdvancedContextType = { |
There was a problem hiding this comment.
same with this one. does it need to be exposed?
There was a problem hiding this comment.
I think it's helpful, no?
There was a problem hiding this comment.
I think I missed it in the other wallet advanced PR, but I don't think we should export WalletAdvancedContextType or include in external docs - it's an internal implementation detail that's unhelpful / confusing to users
Is there a use case you have in mind?
| <WalletAdvanced> | ||
| <WalletAdvancedWalletActions /> | ||
| <WalletAdvancedAddressDetails /> | ||
| <WalletAdvancedTransactionActions /> | ||
| <WalletAdvancedTokenHoldings /> | ||
| </WalletAdvanced> |
There was a problem hiding this comment.
Should we showcase some of the props in action?
| Wallet modal offers users multiple wallet connection options. Explore these options | ||
| [here](/wallet/wallet#using-wallet-modal). | ||
|
|
||
| ## Example usage |
There was a problem hiding this comment.
Could also be good to showcase theming and link to customizing themes
There was a problem hiding this comment.
i like that, esp for the QR codes, will add as a fast-follow
What changed? Why?
WalletAdvanced, includingWalletAdvancedDefault,WalletIsland, and customization optionsNotes to reviewers
How has it been tested?