Dropping python2/pip support #235
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address some of the issues found colcon/colcon-ros-bundle#48.
Issue
For distributions or installs that don't have or need python2/pip this PR addresses that issue. Without this PR you'll get the below error when running
colcon bundle
Or if you are unlucky and the system does have python2 installed you'll receive this which masks the source problem.
Solution
Part of this issue is how
colcon-ros-bundle
is parsing project dependencies and rosdep determines the install. This is true for python dependencies that are installed viapip
. When this happenscolcon-bundle
parses the dep and determines that it is usingpip
for the install. As far as I can tell it does not make a determination between when to usepip
andpip3
and returns what is in the rosdep file. From my findings the only way it will usepip3
is ifpip3
is explicitly defined in the rosdep file which I don't believe is within spec.Since ROS Kinetic has reached EOL, ROS Noetic and on being python3 this PR drops support for python2/pip. To be compatible with rosdep changes the entry point has been changed so any installer of
pip
will usepip3
under the hood.