Skip to content

Conversation

@GentileFulvio
Copy link

@GentileFulvio GentileFulvio commented Nov 24, 2025

This pr tries to fix the inferred types when using implementasync functions for interface implementations. I am uncertain if my fix was the "correct" fix but essentially this fixes the second issue described here #5459.

Now it's still unclear to ma as to why this used to be typed as a MaybeAsync and not a Promise. I assume I am missing some context and by that I also think that there must be something wrong with the change I have done but can't immediately see what. There were no tests indicating what the behavior should be as well

I also wonder why it's only an issue when using the transform function and otherwise it is not.

Another thing I'm wondering is if the output is already types as Promise, should the type still do Promise<T> Or should we check if T already extends Promise so we don't get Promise<Promise<T>> in edge cases.

@vercel
Copy link

vercel bot commented Nov 24, 2025

Someone is attempting to deploy a commit to the colinhacks Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant