Repository navigation
create-site: install plone.app.caching when needed. - #1
Merged
Merged
Conversation
Otherwise a fresh `make stack-start` gives an error in the `create-site` part, when it wants to set caching proxies: ``` KeyError: 'plone.cachepurging.interfaces.ICachePurgingSettings.enabled' ``` Alternatively, we could add `plone.app.caching` to the dependencies of the package, and adds its profile in `metadata.xml`, and make sure `testing.py` loads its zcml, but even then I got errors when running `make test`.
Member
Author
|
Since this is before the initial release, I think a changelog entry is not needed. |
jladage
approved these changes
Oct 8, 2026
jladage
left a comment
jladage
left a comment
Collaborator
There was a problem hiding this comment.
Ah thanks, I might have had code like this in here in the past and removed it, because I didn't install plone.app.caching by hand. Or at least can't remember doing that. :)
Collaborator
|
Hi Maurits,
Are you sure?

Kind regards,
Jean-Paul
… On 8 Oct 2026, at 09:34, Maurits van Rees ***@***.***> wrote:
mauritsvanrees
left a comment
(collective/collective.matomoaitracker#1)
<#1 (comment)>
Since this is before the initial release, I think a changelog entry is not needed.
—
Reply to this email directly, view it on GitHub <#1?email_source=notifications&email_token=AAESTC7EJWQL3LJK3UCFB2L5S5GSBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMBVGU4TSNZSGE4KM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6055997218>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAESTCZQHQIXTTZ2LWQMK735S5GSBAVCNFSNUABGKJSXA33TNF2G64TZHMYTGOJYGY4DMOBTHA5US43TOVSTWNJXGU4DKNJWHA2DBILWAI>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/AAESTC2IBHKYQP3HZPEGMVL5S5GSBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMBVGU4TSNZSGE4KM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android <https://github.com/notifications/mobile/android/AAESTC2FDRDFRHA2VOB4BT35S5GSBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMBVGU4TSNZSGE4KM4TFMFZW63VQOJSXM2LFO5PXEZLROVSXG5DFMSSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today!
You are receiving this because your review was requested.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise a fresh
make stack-startgives an error in thecreate-sitepart, when it wants to set caching proxies:Alternatively, we could add
plone.app.cachingto the dependencies of the package, and adds its profile inmetadata.xml, and make suretesting.pyloads its zcml, but even then I got errors when runningmake test.