Readded: Small Fix for mediaupload problems caused by missing metadata #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation() that prevents linking of newly imported representations to their subject record
type_name_* prematurely set for listing sets by user
Localize Maximum upload size
Localize select options for display settings
Quick fix for Set list by user headings
…ighlight-user-headings-to-help-read-the-listing Set list by user: highlight user headings to help read the listing
using brackets doesn't work for PHP 8, throws deprecation warning in PHP 7.4
Time parser cs
use [] instead of {} for getting character
Bring bracket back into its commented-out block
Localize the default text in required_field_marker, for instances where show_required_field_marker is set to 1. The text to be translated would not be picked up if maintained verbatim (that is, _t((Required)) would not be localized at runtime for some reason tied to the use of parenthesis). Not knowing the escape rules (if any), I've cowardly moved the string to square brackets, with _t([Required]) working as expected. Installs using the default string will notice a change from (Required) to [Required]. Hope it helps anyway.
Localize required_field_marker
patch Chenhall importer with 1.8 backport
"borrowed from" should be "borrowed by"
…ategories for authorities (person and org) and portraits (person and deity). searching on English label
Update docx_results.php : missing field names in the docx export
Update docx_results.php : missing field names in the docx export
Removed duplicate relationship types from dacs_heritage.xml
added several new Nomisma classes for information service, refining c…
…rst level of places Replacing : ca_places_locations_hierarchy_browser_hide_root By : ca_places_hierarchy_browser_hide_root
Change ca_places_locations_hierarchy_browser_hide_root to hide the fi…
Corrected display format for Creator column
Remove "null" date type
Fixing typo in global resourcespace information service settings variable.
Update ResourceSpace.php
…ToCorrectDocumentationOnProfiles Correct the installer link to documentation about profiles
Corrected a typo in dacs_heritage.xml
Enabled client-side caching in the IIIF service.
fixes media-upload when certain meta-data from EXIF is missing
Update gisHelpers.php
|
@CGitPrinz you are trying to merge to dev/php8 from a fork of master. you'll need to rebase/retarget your PR so the CA team can merge it. That said, a quick look at the commits in this changeset suggests c6e86b7 is the only change so they may be able to cherry pick that one directly from your repo if they're willing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a hotfix we needed for our big rollout. There is a better solution, but it requires to rewrite some of the logic in this function (app/helpers/gisHelpers.php: caGISminutesToSignedDecimal)
The upload process of media/files works fine, but when clicking on "Save", we got errors because of missing metadata from those specific images, that are probably needed