fix: app icon not showing on macOS and Windows#1085
Open
minoseigenheer wants to merge 1 commit into
Open
Conversation
macOS:
- Replace broken RESOURCE property with set_source_files_properties
MACOSX_PACKAGE_LOCATION approach so the .icns is correctly copied
into SavvyCAN.app/Contents/Resources/ during the build
- Add Info.plist.cmake with proper CMake variables (CFBundleIconFile set
to SavvyIcon) replacing the qmake-only Info.plist.template that used
incompatible ${ASSETCATALOG_COMPILER_APPICON_NAME} variable
Windows:
- Add icons/SavvyIcon.rc resource file that was referenced in
CMakeLists.txt but missing, which caused the .ico to not be
embedded in the executable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS:
Windows: