Skip to content

Conversation

tjdcs
Copy link
Contributor

@tjdcs tjdcs commented Oct 29, 2023

Add an xy implementation to is_within_visible_spectrum for brightness invariant checking.

@KelSolaar
Copy link
Member

I think that I would prefer a dedicated separate public definition instead of magic based on the shape. What about something like renaming the current one to is_within_visible_spectrum_volume and the xy one is_within_visible_spectrum_area?

Cheers,

@tjdcs tjdcs force-pushed the feature/is_visible_xy branch from 58847cb to ceba79e Compare January 5, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants