-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix publishing for 2.13.16 and 3.6.3 #1603
Conversation
3.6.3 is green now. 2.13.16 has an issue related to completion import java.| would lead to haven't been able to go far from the error message, but this could be related to scala/scala#10868. |
Thanks @kiendang ! |
to work around compiler error
@lihaoyi 2.13.16 is also green now. Work around the upstream issue by tweaking the autocomplete code wrapper. See scala/scala#10868 (comment). |
Thanks @kiendang ! Could you fill out the PR description with a summary of your changes in Scala 2 and 3, along with links to the upstream tickets? Then I can merge this and transfer the bounty |
@lihaoyi done. I've also just updated so the diff is minimal now. For 3.6.3 |
Thanks @kiendang! I'll transfer the bounty using the bank details we for the last one |
3.6.3
DottyParser.blockStatSeq
signature change from 3.6.2 to 3.6.3See scala/scala3@3.6.2...3.6.3#diff-89e03cdd16b8e5fd6435d2df4b44a3e58c408a22adb7683c149015ab0d64f4bfR4717
Thus the current
amm/compiler/src/main/scala-3/DottyParser.scala
is moved to.../scala-3.0.0-3.6.2/DottyParser.scala
. A new.../scala-3.6.3+/DottyParser.scala
was created with the new signature.build.mill
was updated accordingly.2.13.16
A change in upstream (Issue messages at import selector only [ci: last-only] scala/scala#10868) caused an error in autocompletion. Attempting to autocomplete
import java.|
would trigger the error. The workaround is to change the autocomplete code wrapper to(similar to Scala 3)
instead of