Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala Spark example doc page #4513

Merged
merged 15 commits into from
Feb 10, 2025
Merged

Conversation

monyedavid
Copy link
Contributor

@monyedavid monyedavid commented Feb 8, 2025

This pr implements the examples for spark

Closes Issue 4453

Checklist:

  • example/scalalib/spark
    • 1-hello-saprk
    • 2-hello-pyspark
    • 3-semi-realistic (+ spark-submit)

@lihaoyi
Copy link
Member

lihaoyi commented Feb 10, 2025

I think this looks great. @monyedavid please add the new page to nav.adoc and open a backport PR to the 0.12.x branch, and I'll merge them both

# Conflicts:
#	website/docs/modules/ROOT/pages/scalalib/spark.adoc
@monyedavid
Copy link
Contributor Author

I will open the back port once this is merged @lihaoyi

@lihaoyi lihaoyi merged commit a40b5b0 into com-lihaoyi:main Feb 10, 2025
27 of 31 checks passed
monyedavid added a commit to monyedavid/mill that referenced this pull request Feb 10, 2025
This pr implements the examples for spark

Closes [Issue 4453](com-lihaoyi#4453)

Checklist:
- [x] **example/scalalib/spark**
     - [x]  1-hello-saprk
     - [x]  2-hello-pyspark
     - [x]  3-semi-realistic (+ spark-submit)

(cherry picked from commit a40b5b0)
@lefou lefou added this to the 0.13.0 milestone Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Scala Spark example doc page (500USD Bounty)
3 participants