refactor: allow for customSheetName to be an empty string
#263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolgab
reviewed
Jan 28, 2023
Open
While you could do this before, if you had a class `a` and you wanted to keep it simple and not have anything for your `customSheetName` you'd end up with `-a` which was a bit annoying. This small change allows users to still use this the way the were before, but now if they are using an empty string as their `customSheetName`, they'll just get `a` instead of `-a`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While you could do this before, if you had a class
aand you wanted tokeep it simple and not have anything for your
customSheetNameyou'dend up with
-awhich was a bit annoying. This small change allowsusers to still use this the way the were before, but now if they are
using an empty string as their
customSheetName, they'll just getainstead of
-a.