Delete assigned resource must return HTTP status code 409 Conflict - #693
Merged
david-monichi merged 4 commits intoJul 24, 2026
Merged
Conversation
…d location Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
Signed-off-by: Stiliyan Valkanov <stiliyan.valkanov@bearingpoint.com>
clepski
previously approved these changes
Jul 21, 2026
Signed-off-by: David Monichi <david.monichi@bearingpoint.com>
|
Contributor
|
@clepski Hi, I just did a code cleanup and we would need your approval. Somehow this feels like a situation we mentioned last Retro where we should be able to merge ourself without your approval (just the code cleanup). @Sander3003 Is it possible that at least I get the permission to merge for such cases? |
Member
|
Yes, let me check the permissions. |
Member
|
Bearingpoint has maintainer rights now. |
Contributor
Thx, we will use them as we agreed on. |
david-monichi
self-requested a review
July 24, 2026 08:50
david-monichi
approved these changes
Jul 24, 2026
Contributor
|
@Sander3003 I guess for development you would need to approve this PR: |
clepski
approved these changes
Jul 24, 2026
david-monichi
deleted the
fix/issue-692_delete-assigned-location-returns-409
branch
July 24, 2026 12:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Changes Made:
CompasAssignedLocationExceptionfor cases when a location with assigned resources is attempted to be deleted.LocationsService.deleteLocationto throwCompasAssignedLocationExceptioninstead of the more genericCompasSclDataServiceExceptionwhen deletion is not allowed.CompasAssignedLocationExceptionHandlerto mapCompasAssignedLocationExceptionto a 409 Conflict HTTP response with a structured error body.Testing Updates:
CompasAssignedLocationExceptionHandlerto verify correct error response mapping.CompasAssignedLocationExceptioninstead of the previous exception.