Skip to content

ci: docker: correctly handle outputs #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
melekes merged 2 commits into from
Mar 3, 2025
Merged

ci: docker: correctly handle outputs #250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce72ec5
Revert "ci: docker: do not override digest (#249)"
melekes Mar 3, 2025
05f51c6
ci: docker: correct handling of outputs
melekes Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
cancel-in-progress: true

env:
ORG: cometbft
Expand All @@ -29,14 +29,14 @@ jobs:
include:
- os: ubuntu-24.04
platform: linux/amd64
platform_short: amd64
arch: amd64
- os: ubuntu-24.04-arm
platform: linux/arm64
platform_short: arm64
arch: arm64
runs-on: ${{ matrix.os }}
outputs:
digest_amd64: ${{ steps.build-amd64.outputs.digest }}
digest_arm64: ${{ steps.build-arm64.outputs.digest }}
digest_amd64: ${{ steps.capture-digest.outputs.digest_amd64 }}
digest_arm64: ${{ steps.capture-digest.outputs.digest_arm64 }}
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -54,14 +54,19 @@ jobs:
password: ${{ secrets.DOCKERHUB_TOKEN }}

- name: Build and push image
id: build-${{ matrix.platform_short }}
id: build
uses: docker/build-push-action@v6
with:
platforms: ${{ matrix.platform }}
file: ./tools/Dockerfile
tags: |
${{ env.ORG }}/${{ env.IMAGE_NAME }}:${{ env.GIT_TAG }}
push: true
outputs: type=image,name=${{ env.ORG }}/${{ env.IMAGE_NAME }},digest=true

- name: Capture Image Digest
id: capture-digest
run: echo "digest_${{ matrix.arch }}=${{ steps.build.outputs.digest }}" >> $GITHUB_ENV

merge:
runs-on: ubuntu-latest
Expand Down
Loading