VW MQB: release standstill hold on gas override - #3536
Open
andiradulescu wants to merge 2 commits into
Open
Conversation
andiradulescu
force-pushed
the
vw-mqb-gas-override-hold-release
branch
from
July 12, 2026 23:45
93b20ee to
54adab4
Compare
Contributor
Car behavior reportReplays driving segments through this PR and compares the behavior to master. Testing 130 segments for: VOLKSWAGEN_ARTEON_MK1, VOLKSWAGEN_ATLAS_MK1, VOLKSWAGEN_CRAFTER_MK2, VOLKSWAGEN_GOLF_MK7, VOLKSWAGEN_JETTA_MK7, VOLKSWAGEN_PASSAT_MK8, VOLKSWAGEN_PASSAT_NMS, VOLKSWAGEN_POLO_MK6, VOLKSWAGEN_TAOS_MK1, VOLKSWAGEN_TIGUAN_MK2, VOLKSWAGEN_TOURAN_MK2, VOLKSWAGEN_TRANSPORTER_T61, VOLKSWAGEN_TROC_MK1 ✅ 0 changed, 130 passed, 0 errors |
andiradulescu
force-pushed
the
vw-mqb-gas-override-hold-release
branch
from
July 13, 2026 18:30
54adab4 to
6537758
Compare
andiradulescu
changed the title
Co-authored-by: Andrei Radulescu <andi.radulescu@gmail.com>
andiradulescu
force-pushed
the
vw-mqb-gas-override-hold-release
branch
from
July 13, 2026 19:11
6537758 to
4fb2ce4
Compare
Contributor
|
Can you see if MQB could just use the MEB long state machine class? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of @jyoung8607’s mqb-accel-override
Fixes #1159
Keep ACC in the driver-override state and request standstill hold release when accelerating from a stop while engaged. Send VW’s inactive acceleration value while openpilot longitudinal control is overridden.
Although happens way less often than in 2023/2024, it still happens to brake for ~1s when overriding from a standstill.
Validation
EDIT: this might not be needed anymore if #3135 and #3165 get merged.