Repository navigation
Switch to esm - #178
Merged
Merged
Switch to esm#178
Conversation
abetomo
reviewed
May 27, 2026
abetomo
approved these changes
May 27, 2026
shadowspawn
added
pending release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following patterns in Commander, I have switched over to pure ESM. (I had forgotten I hadn't done that yet. 😅 )
The noisy change is that imports need to have explicit file name and extension.
A simplification I made is to just reexport all of the Commander exports. In Commander 11 the default export was a Command singleton with the other named exports bolted on. I wanted the
extra-typingsexport to be clean. That extra processing is no longer required now that Commander has tidy exports: tj/commander.js#2017