FCT 1514 - Accessibility Adjustments #3116
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| case 'brown': | ||
| return designTokens.colorBrown35; | ||
| case 'purple': | ||
| return designTokens.colorPurple50; | ||
| case 'turquoise': | ||
| return designTokens.colorTurquoise35; | ||
| default: | ||
| return designTokens[ | ||
| `color${startCase(avatarColor)}50` as keyof typeof designTokens | ||
| ]; | ||
| return designTokens.colorAccent30; |
There was a problem hiding this comment.
brown & accent no longer share the same lightness value (50%), so i left accent as the default to match the readme file.
| @@ -29,7 +29,7 @@ | |||
| --color-accent-98: hsl(195, 100%, 98%); | |||
| --color-brown-10: hsl(41, 100%, 10%); | |||
| --color-brown-20: hsl(41, 100%, 20%); | |||
| --color-brown-35: hsl(41, 96%, 35%); | |||
| --color-brown-35: hsl(41, 96%, 30%); | |||
There was a problem hiding this comment.
@FilPob, @misama-ct i noticed that the vast majority of the property names (not all) match the light value.
would you like for these to follow that format, or no? figma didn't have this, so wanted to check before i became too creative.
There was a problem hiding this comment.
No, please don’t. The old token-/color-system is flawed. HSL is a rather mathematical, not a 100% perceptual colorspace. This means the “lightness” channel in hsl is not actually reflecting a uniform lightness value across the colorspace.
valoriecarli
requested review from
stephsprinkle,
jaikamat,
ddouglasz,
tylermorrisford,
ByronDWall and
misama-ct
and removed request for
a team
valoriecarli
added
👨🎨 Status: UI/UX Review
valoriecarli
force-pushed
the
FCT-1514-accessibility-adjustments
branch
from
72fae4e to
1839af2
Compare
1.) Adjust following color values (figma ref):
2.) Change following Avatar color decisions (figma ref):