Skip to content

[PANGOLIN-3857] update z-index for filter menu dropdown #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025

Conversation

kterry1
Copy link
Contributor

@kterry1 kterry1 commented May 21, 2025

Summary

The portals-container element for a drawer has a z-index of 10000 and when the Filter component is inside a drawer, the menu dropdown is covered as it has a z-index of 5. I updated the z-index of the menu styles for the Filter component but if I missed another spot that needs updated here please let me know.

Description

Screen.Recording.2025-05-21.at.4.04.53.PM.mov

@kterry1 kterry1 requested a review from a team as a code owner May 21, 2025 20:57
@kterry1 kterry1 requested review from stephsprinkle, jaikamat, ddouglasz, valoriecarli, tylermorrisford, ByronDWall and misama-ct and removed request for a team May 21, 2025 20:57
Copy link

changeset-bot bot commented May 21, 2025

⚠️ No Changeset found

Latest commit: 92a0d63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 9:08pm

@kterry1 kterry1 self-assigned this May 21, 2025
@kterry1 kterry1 requested a review from Sarah4VT May 21, 2025 20:58
@kterry1 kterry1 added 👨‍🎨 Status: UI/UX Review Requires review from design team 🙏 Status: Dev Review Waiting for technical reviews labels May 21, 2025
@Sarah4VT
Copy link
Contributor

Summary

The portals-container element for a drawer has a z-index of 10000 and when the Filter component is inside a drawer, the menu dropdown is covered as it has a z-index of 5. I updated the z-index of the menu styles for the Filter component but if I missed another spot that needs updated here please let me know.

Description

Screen.Recording.2025-05-21.at.4.04.53.PM.mov

One thing to note is the extra space between the Filter row and the grid in @kterry1 's recording was manually added during debugging to figure out what was causing the menu to not appear.

Copy link
Contributor

@misama-ct misama-ct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for figuring a solution out on your own, I know this stacking issues are no fun to debug 🙇‍♂️

Copy link
Contributor

@ddouglasz ddouglasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

@kterry1
Copy link
Contributor Author

kterry1 commented May 26, 2025

Thank you both @misama-ct @ddouglasz. Are either of you able to merge here? I don't appear to have access to do so.

@valoriecarli valoriecarli merged commit dc9887b into main May 26, 2025
12 checks passed
@valoriecarli valoriecarli deleted the PANGOLIN-3847-in-context-filter-menu branch May 26, 2025 14:44
@valoriecarli
Copy link
Contributor

valoriecarli commented May 26, 2025

Thank you both @misama-ct @ddouglasz. Are either of you able to merge here? I don't appear to have access to do so.

@kterry1 merged. ill let you know when it's been released.

@kterry1
Copy link
Contributor Author

kterry1 commented May 26, 2025

Thanks @valoriecarli!

@ct-changesets ct-changesets bot mentioned this pull request May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙏 Status: Dev Review Waiting for technical reviews 👨‍🎨 Status: UI/UX Review Requires review from design team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants