Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for manual version bumping #99

Merged

Conversation

ckagerer
Copy link
Contributor

Add the feature requested in #81.

@ckagerer
Copy link
Contributor Author

@woile @Lee-W @noirbizarre Please check this Pull Request,

I think it would be good if this repo also had a CODEOWNERS file. Otherwise, it's not clear who checks the pull requests.

Sorry if I'm annoying you :)

@Lee-W
Copy link
Member

Lee-W commented Feb 20, 2025

I'll take a look later this week

@Lee-W
Copy link
Member

Lee-W commented Feb 23, 2025

overall, it looks good. not sure what fails the CI. might need to take a look

@ckagerer
Copy link
Contributor Author

I think the CI is failing because there are no tags in the fork “No tag found to do an incremental changelog”. I have created a tag for the latest version. Hope it works.

@Lee-W
Copy link
Member

Lee-W commented Feb 23, 2025

I think the CI is failing because there are no tags in the fork “No tag found to do an incremental changelog”. I have created a tag for the latest version. Hope it works.

hmmm... not sure why folk will affect the CI on our end, but looks good to me. Will keep it open for one or two days so @woile and @noirbizarre can take a look

@ckagerer
Copy link
Contributor Author

After I tagged the last release in my fork, it went through.
The problem is that the action simulates the next release. But when you create a fork at GitHub, which I need to submit the PR, existing tags are apparently not copied. The action clones my fork because it contains my feature branch. That's why the pipeline breaks off because the tag of the last release is missing.

All right. And thanks for the review.

@Lee-W
Copy link
Member

Lee-W commented Feb 25, 2025

Thanks so much for helping us investigate it. I was to do it but not yet have the bandwidth

, existing tags are apparently not copied.

Sounds like something we need to fix. But I'll merge this now and probably get back to this later. Thanks!

@Lee-W Lee-W merged commit 4787c27 into commitizen-tools:master Feb 25, 2025
1 check passed
@ckagerer ckagerer deleted the feature/support-for-manual-version branch March 1, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants