Skip to content

BookmarkLocationsFragment.kt:fix android studio warnings for this fi… #6283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2025
Merged

BookmarkLocationsFragment.kt:fix android studio warnings for this fi… #6283

merged 1 commit into from
Apr 13, 2025

Conversation

Prinuel
Copy link
Contributor

@Prinuel Prinuel commented Apr 12, 2025 •
edited
Loading

Fixes #5996 : Fix one of android studio warnings

What changes did you make and why?

  1. i removed three unused import directives: - import android.annotation.SuppressLint, - import androidx.lifecycle.Lifecycle and - import androidx.lifecycle.repeatOnLifecycle; This helps declutter the code, and reduce unused code.
  2. converted to two occureneces of the call to the method object: FilePicker.HandleActivityResult, in contributionController.handleActivityResultWithCallback, to use lamda functions. This makes the code more compact, and readable.

Tests performed (required)

Tested the Debug Beta on Android (Samsung Galaxy A21s), Api level 31

@bethel-m
BookmarkLocationsFragment.kt:fix android studio warnings for this fi…
6a4d672 
…le, : Eliminated three unused imports, and changed calls to object: FilePicker.HandleActivityResult to use lamda
@github-actions GitHub Actions
Copy link

✅ Generated APK variants!

@nicolas-raoul nicolas-raoul merged commit 4bacac1 into commons-app:main Apr 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-raoul nicolas-raoul nicolas-raoul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix one of the Android Studio warnings
3 participants
@Prinuel @nicolas-raoul @bethel-m