Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PingVin: Fix problem with update und switch to new method of getting files. #1819

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

michelroegl-brunner
Copy link
Member

@michelroegl-brunner michelroegl-brunner commented Jan 28, 2025

✍️ Description

Fix problem with update und switch to new method of getting files.



✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • [] New feature (non-breaking change that adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • [] New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

@michelroegl-brunner michelroegl-brunner requested a review from a team as a code owner January 28, 2025 14:17
@github-actions github-actions bot added the update script A change that updates a script label Jan 28, 2025
@MickLesk
Copy link
Member

short guide needed for users. breaking change.
if you check on RELEASE_.txt, and there is no file, it breaks the update?

@michelroegl-brunner
Copy link
Member Author

Yep, added the guide on how to mitigate this.

@MickLesk MickLesk merged commit 97002e7 into main Jan 28, 2025
3 checks passed
@MickLesk MickLesk added the breaking change A change that is not backward compatible label Jan 28, 2025
@MickLesk
Copy link
Member

Guide: #1822

@MickLesk MickLesk changed the title Update pingvin.sh and pingvin-install.sh: Fix problem with update und switch to new method of getting files. Update PingVin: Fix problem with update und switch to new method of getting files. Jan 28, 2025
@MickLesk MickLesk deleted the pingvin branch January 29, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A change that is not backward compatible update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants