Skip to content

chore: split lighting shader - #2241

Draft
Gistix wants to merge 3 commits into
community-shaders:devfrom
Gistix:lighting-split
Draft

chore: split lighting shader#2241
Gistix wants to merge 3 commits into
community-shaders:devfrom
Gistix:lighting-split

Conversation

@Gistix

@Gistix Gistix commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Splits lighting shader file logically by techniques, while also taking care of reducing redundancy across them.

Its split into 5 shaders:

  • EnvMap, MultilayerParallax and Eye
  • MTLand and MTLandLODBlend
  • LODLand, LODObjects, LODObjectHD and LODLandNoise
  • TreeAnim
  • Other techniques

Current status:

  • Adjust shader cache to properly use the new shader paths
  • Split shaders
  • Cleanup
  • Make shared logic into functions to reduce redundancy
  • Make Lighting.PBR.hlsl as well (optional?)

@coderabbitai

coderabbitai Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3657ddb3-f2f1-478a-b3fe-788514b4b887

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

No actionable suggestions for changed features.

@davo0411

davo0411 commented May 7, 2026

Copy link
Copy Markdown
Collaborator

tv/parallax update will break this unfortunately. also would it be easier for us to make a new lighting folder for Lighting shaders?

@Gistix

Gistix commented May 8, 2026

Copy link
Copy Markdown
Contributor Author

tv/parallax update will break this unfortunately. also would it be easier for us to make a new lighting folder for Lighting shaders?

I used a script to split the shaders (which is why it requires manual cleaning), I'll run it again after tv/parallax update is merged
Yes it could be done, we'd just have to change the path function in ShaderCache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants