chore(effects11): remove SKYSCATTERING

[doodlum]

Summary by CodeRabbit

• Bug Fixes
  • Removed cloud-scattering and sky-scattering effects from the visual rendering pipeline.
  • Cloud lighting now uses cloud-edge transparency for more consistent edge shading and improved visual stability.
  • Removed configuration options related to the discontinued scattering effects.
  • Simplified sky rendering by eliminating inconsistent procedural scattering and randomized cloud-lighting behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The change removes cloud-scattering settings from shared and per-frame data, removes their effect configuration, and deletes procedural cloud-shadow and scattering calculations from the sky shader.

Changes

Cloud scattering removal

Layer / File(s)	Summary
Remove cloud-scattering settings and frame data package/Shaders/Common/SharedData.hlsli, src/Features/Effects11.*, src/Features/Effects11/EffectManager.cpp	Removes cloud-scattering fields, frame-data assignments, effect settings, category dependencies, and exterior-only configuration.
Remove cloud-scattering shader calculations package/Shaders/Sky.hlsl	Removes random and cloud-shadow includes, procedural scattering, shadow sampling, and randomized cloud lighting. Cloud edge phases now use cloudsEdgeAlpha directly.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• community-shaders/skyrim-community-shaders#2302: Modifies the same shared data, effects, and sky-shader cloud-scattering paths.
• community-shaders/skyrim-community-shaders#2593: Modifies the corresponding cloud-scattering fields and Sky.hlsl implementation.
• community-shaders/skyrim-community-shaders#2090: Modifies cloud-shadow and sun-lighting behavior in Sky.hlsl.

Suggested reviewers: davo0411, jiayev

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely identifies the removal of SKYSCATTERING, which is the main change in the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/remove-effects11-skyscattering

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

No actionable suggestions for changed features.

[github-actions]

✅ A pre-release build is available for this PR:
Download

[coderabbitai]

🧹 Nitpick comments (1)

package/Shaders/Sky.hlsl (1)

1-5: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Use a lowercase Conventional Commit title.

chore(effects11): remove SKYSCATTERING uses the correct structure, but the description is not lowercase. Use chore(effects11): remove skyscattering or chore(effects11): remove sky scattering. If this change tracks an issue, add Implements #<issue> or Addresses #<issue> to the PR description.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package/Shaders/Sky.hlsl` around lines 1 - 5, Update the commit title to use
a lowercase description, such as “chore(effects11): remove skyscattering” or
“chore(effects11): remove sky scattering”; if applicable, add the referenced
issue linkage to the PR description.

Source: Path instructions

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@package/Shaders/Sky.hlsl`:
- Around line 1-5: Update the commit title to use a lowercase description, such
as “chore(effects11): remove skyscattering” or “chore(effects11): remove sky
scattering”; if applicable, add the referenced issue linkage to the PR
description.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ccd7363c-b017-43d7-82fe-fdbe0298f372

📥 Commits

Reviewing files that changed from the base of the PR and between 06e6f47 and f774e37.

📒 Files selected for processing (1)

• package/Shaders/Sky.hlsl