Library autoloader by alexander-penev · Pull Request #308 · compiler-research/CppInterOp

alexander-penev · 2024-07-10T17:28:53Z

No description provided.

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 12. Check the log or trigger a new build to see more.

lib/Interpreter/CppInterOp.cpp

codecov · 2024-07-10T17:40:19Z

Codecov Report

Attention: Patch coverage is 82.75862% with 15 lines in your changes missing coverage. Please review.

Project coverage is 74.30%. Comparing base (e0fa91e) to head (6cfe873).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
+ Coverage   72.22%   74.30%   +2.07%     
==========================================
  Files           8        8              
  Lines        2963     3043      +80     
==========================================
+ Hits         2140     2261     +121     
+ Misses        823      782      -41

Files	Coverage Δ
include/clang/Interpreter/CppInterOp.h	`96.00% <ø> (ø)`
lib/Interpreter/DynamicLibraryManagerSymbol.cpp	`74.56% <ø> (+6.91%)`	⬆️
lib/Interpreter/DynamicLibraryManager.cpp	`77.77% <60.00%> (+5.40%)`	⬆️
lib/Interpreter/CppInterOp.cpp	`78.79% <84.14%> (+0.26%)`	⬆️

... and 2 files with indirect coverage changes

Files	Coverage Δ
include/clang/Interpreter/CppInterOp.h	`96.00% <ø> (ø)`
lib/Interpreter/DynamicLibraryManagerSymbol.cpp	`74.56% <ø> (+6.91%)`	⬆️
lib/Interpreter/DynamicLibraryManager.cpp	`77.77% <60.00%> (+5.40%)`	⬆️
lib/Interpreter/CppInterOp.cpp	`78.79% <84.14%> (+0.26%)`	⬆️

... and 2 files with indirect coverage changes

github-actions

clang-tidy made some suggestions

lib/Interpreter/CppInterOp.cpp

lib/Interpreter/DynamicLibraryManager.cpp

unittests/CppInterOp/TestSharedLib1/TestSharedLib1.h

github-actions

clang-tidy made some suggestions

lib/Interpreter/CppInterOp.cpp

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 14. Check the log or trigger a new build to see more.

lib/Interpreter/CppInterOp.cpp

unittests/CppInterOp/DynamicLibraryManagerTest.cpp

include/clang/Interpreter/CppInterOp.h

lib/Interpreter/CppInterOp.cpp

lib/Interpreter/DynamicLibraryManagerSymbol.cpp

unittests/CppInterOp/CMakeLists.txt

unittests/CppInterOp/DynamicLibraryManagerTest.cpp

unittests/CppInterOp/TestSharedLib1/CMakeLists.txt

github-actions

clang-tidy made some suggestions

unittests/CppInterOp/DynamicLibraryManagerTest.cpp

unittests/CppInterOp/TestSharedLib2/TestSharedLib2.h

unittests/CppInterOp/TestSharedLib3/TestSharedLib3.h

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 18. Check the log or trigger a new build to see more.

lib/Interpreter/CppInterOp.cpp

github-actions

clang-tidy made some suggestions

lib/Interpreter/CppInterOp.cpp

lhames · 2024-08-02T04:09:30Z

A couple of quick thoughts for future upstreaming: we'd want to make this compatible with out-of-process execution, and it'd be great if we could re-use parts of it for MachO auto-linking.

We should consider whether SimpleExecutorDylibManager can be extended to handle all this.

vgvassilev · 2024-08-02T08:29:49Z

A couple of quick thoughts for future upstreaming: we'd want to make this compatible with out-of-process execution, and it'd be great if we could re-use parts of it for MachO auto-linking.

Thanks for the feedback, @lhames. That makes sense.

We should consider whether SimpleExecutorDylibManager can be extended to handle all this.

I was not aware such a thing existed. @SahilPatidar perhaps that's interesting in terms of your project, too.

github-actions

clang-tidy made some suggestions

lib/Interpreter/CppInterOp.cpp

github-actions

clang-tidy made some suggestions

github-actions · 2024-09-19T11:01:50Z

lib/Interpreter/CppInterOp.cpp

+    }
+
+    void setEnabled(bool enabled) {
+      Enabled = enabled;


warning: method 'isEnabled' can be made const [readability-make-member-function-const]

Suggested change

Enabled = enabled;

bool isEnabled() const {

github-actions · 2024-09-19T11:01:50Z

lib/Interpreter/CppInterOp.cpp

+      }
+
+      void materialize(std::unique_ptr<llvm::orc::MaterializationResponsibility> R) override {
+        if (!sAutoSG || !sAutoSG->isEnabled()) {


warning: function 'getName' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

if (!sAutoSG || !sAutoSG->isEnabled()) {

[[nodiscard]] StringRef getName() const override {

vgvassilev · 2024-09-19T16:56:51Z

@aaronj0, do you have a clue why cppyy fails?

aaronj0 · 2024-09-20T09:09:51Z

@aaronj0, do you have a clue why cppyy fails?

cppyy does not fail, InterOp does not build on any of the jobs. This comes back to the point that CppInterOp is only built on the jobs tagged with "cppyy" not the first stage that only builds llvm.

On a preliminary look, it seems like on llvm19 we get:

error: no matching function for call to ‘llvm::orc::MaterializationResponsibility::notifyEmitted()’
 3470 |           llvm::cantFail(R->notifyEmitted());

and on 18 and 17, these "undefined reference to typeinfo for llvm::orc::DefinitionGenerator"

They also fail in some of the emscripten builds but I am more interested in the fact that they pass on llvm 17 and 18 with clang-repl on all platforms

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 21. Check the log or trigger a new build to see more.

github-actions · 2024-12-12T19:35:51Z

lib/Interpreter/CppInterOp.cpp

+  class AutoLoadLibrarySearchGenerator : public llvm::orc::DefinitionGenerator {
+    bool Enabled = false;
+  public:
+    bool isEnabled() {


warning: method 'isEnabled' can be made const [readability-make-member-function-const]

Suggested change

bool isEnabled() {

bool isEnabled() const {

github-actions · 2024-12-12T19:35:51Z

lib/Interpreter/CppInterOp.cpp

+      AutoloadLibraryMU(std::string Library, const llvm::orc::SymbolNameVector &Symbols)
+        : MaterializationUnit({getSymbolFlagsMap(Symbols), nullptr}), lib(std::move(Library)), syms(Symbols) {}
+
+      StringRef getName() const override {


warning: function 'getName' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

StringRef getName() const override {

[[nodiscard]] StringRef getName() const override {

github-actions · 2024-12-12T19:35:51Z

lib/Interpreter/CppInterOp.cpp

+      }
+
+      void materialize(std::unique_ptr<llvm::orc::MaterializationResponsibility> R) override {
+        if (!sAutoSG || !sAutoSG->isEnabled()) {


warning: use of undeclared identifier 'sAutoSG' [clang-diagnostic-error]

if (!sAutoSG || !sAutoSG->isEnabled()) { ^

github-actions · 2024-12-12T19:35:51Z

lib/Interpreter/CppInterOp.cpp

+      }
+
+      void materialize(std::unique_ptr<llvm::orc::MaterializationResponsibility> R) override {
+        if (!sAutoSG || !sAutoSG->isEnabled()) {


warning: use of undeclared identifier 'sAutoSG' [clang-diagnostic-error]

if (!sAutoSG || !sAutoSG->isEnabled()) { ^

github-actions · 2024-12-12T19:35:51Z

lib/Interpreter/CppInterOp.cpp

+        }
+
+        if (!loadedSymbols.empty()) {
+          llvm::cantFail(R->notifyResolved(loadedSymbols));


warning: no header providing "llvm::cantFail" is directly included [misc-include-cleaner]

llvm::cantFail(R->notifyResolved(loadedSymbols)); ^

github-actions · 2024-12-12T19:35:51Z

lib/Interpreter/CppInterOp.cpp

+      auto& I = getInterp();
+      auto *DLM = I.getDynamicLibraryManager();
+
+      std::unordered_map<std::string, llvm::orc::SymbolNameVector> found;


warning: no header providing "std::unordered_map" is directly included [misc-include-cleaner]

lib/Interpreter/CppInterOp.cpp:26:

- #if CLANG_VERSION_MAJOR >= 19 + #include <unordered_map> + #if CLANG_VERSION_MAJOR >= 19

github-actions · 2024-12-12T19:35:51Z

lib/Interpreter/CppInterOp.cpp

+      }
+
+      for (auto &&KV : found) {
+	auto MU = std::make_unique<AutoloadLibraryMU>(KV.first, std::move(KV.second));


warning: no header providing "std::make_unique" is directly included [misc-include-cleaner]

auto MU = std::make_unique<AutoloadLibraryMU>(KV.first, std::move(KV.second)); ^

github-actions · 2024-12-12T19:35:51Z

lib/Interpreter/CppInterOp.cpp

+    llvm::orc::JITDylib& DyLib = *EE.getProcessSymbolsJITDylib().get();
+#endif // CLANG_VERSION_MAJOR
+
+    if (!sAutoSG) {


warning: use of undeclared identifier 'sAutoSG' [clang-diagnostic-error]

if (!sAutoSG) { ^

github-actions · 2024-12-12T19:35:51Z

lib/Interpreter/CppInterOp.cpp

+#endif // CLANG_VERSION_MAJOR
+
+    if (!sAutoSG) {
+      sAutoSG = &DyLib.addGenerator(std::make_unique<AutoLoadLibrarySearchGenerator>());


warning: use of undeclared identifier 'sAutoSG' [clang-diagnostic-error]

sAutoSG = &DyLib.addGenerator(std::make_unique<AutoLoadLibrarySearchGenerator>()); ^

github-actions · 2024-12-12T19:35:51Z

lib/Interpreter/CppInterOp.cpp

+    if (!sAutoSG) {
+      sAutoSG = &DyLib.addGenerator(std::make_unique<AutoLoadLibrarySearchGenerator>());
+    }
+    sAutoSG->setEnabled(autoload);


warning: use of undeclared identifier 'sAutoSG' [clang-diagnostic-error]

sAutoSG->setEnabled(autoload); ^

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 11. Check the log or trigger a new build to see more.

github-actions · 2024-12-12T19:41:39Z

lib/Interpreter/CppInterOp.cpp

+
+  bool GetLibrariesAutoload() {
+    LLVM_DEBUG(dbgs() << "Autoload is " << (sAutoSG && sAutoSG->isEnabled() ? "ON" : "OFF"));
+    return sAutoSG && sAutoSG->isEnabled();


warning: use of undeclared identifier 'sAutoSG' [clang-diagnostic-error]

return sAutoSG && sAutoSG->isEnabled(); ^

github-actions · 2024-12-12T19:41:40Z

lib/Interpreter/CppInterOp.cpp

+
+  bool GetLibrariesAutoload() {
+    LLVM_DEBUG(dbgs() << "Autoload is " << (sAutoSG && sAutoSG->isEnabled() ? "ON" : "OFF"));
+    return sAutoSG && sAutoSG->isEnabled();


warning: use of undeclared identifier 'sAutoSG' [clang-diagnostic-error]

return sAutoSG && sAutoSG->isEnabled(); ^

github-actions · 2024-12-12T19:41:40Z

unittests/CppInterOp/DynamicLibraryManagerTest.cpp


+
+#include "llvm/ExecutionEngine/Orc/Core.h"
+#include "llvm/ExecutionEngine/Orc/DebugUtils.h"


warning: included header Core.h is not used directly [misc-include-cleaner]

Suggested change

#include "llvm/ExecutionEngine/Orc/DebugUtils.h"

#include "llvm/ExecutionEngine/Orc/DebugUtils.h"

github-actions · 2024-12-12T19:41:40Z

unittests/CppInterOp/DynamicLibraryManagerTest.cpp

+
+#include "llvm/ExecutionEngine/Orc/Core.h"
+#include "llvm/ExecutionEngine/Orc/DebugUtils.h"
 #include "llvm/Support/FileSystem.h"


warning: included header DebugUtils.h is not used directly [misc-include-cleaner]

Suggested change

#include "llvm/Support/FileSystem.h"

#include "llvm/Support/FileSystem.h"

github-actions · 2024-12-12T19:41:40Z

unittests/CppInterOp/DynamicLibraryManagerTest.cpp

 // address of main, and some platforms can't implement GetMainExecutable
 // without being given the address of a function in the main executable).
-std::string GetExecutablePath(const char* Argv0) {
+std::string GetExecutablePath(const char* Argv0, void* mainAddr = nullptr) {


warning: no header providing "std::string" is directly included [misc-include-cleaner]

unittests/CppInterOp/DynamicLibraryManagerTest.cpp:10:

+ #include <string>

github-actions · 2024-12-12T19:41:41Z

unittests/CppInterOp/DynamicLibraryManagerTest.cpp

  // This just needs to be some symbol in the binary; C++ doesn't
  // allow taking the address of ::main however.
-  void* MainAddr = (void*)intptr_t(GetExecutablePath);
+  void* MainAddr = mainAddr ? mainAddr : (void*)intptr_t(GetExecutablePath);


warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]

void* MainAddr = mainAddr ? mainAddr : (void*)intptr_t(GetExecutablePath); ^

github-actions · 2024-12-12T19:41:41Z

unittests/CppInterOp/DynamicLibraryManagerTest.cpp

  // This just needs to be some symbol in the binary; C++ doesn't
  // allow taking the address of ::main however.
-  void* MainAddr = (void*)intptr_t(GetExecutablePath);
+  void* MainAddr = mainAddr ? mainAddr : (void*)intptr_t(GetExecutablePath);


warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr]

void* MainAddr = mainAddr ? mainAddr : (void*)intptr_t(GetExecutablePath); ^

github-actions · 2024-12-12T19:41:41Z

unittests/CppInterOp/DynamicLibraryManagerTest.cpp

  // This just needs to be some symbol in the binary; C++ doesn't
  // allow taking the address of ::main however.
-  void* MainAddr = (void*)intptr_t(GetExecutablePath);
+  void* MainAddr = mainAddr ? mainAddr : (void*)intptr_t(GetExecutablePath);


warning: no header providing "intptr_t" is directly included [misc-include-cleaner]

unittests/CppInterOp/DynamicLibraryManagerTest.cpp:10:

+ #include <cstdint>

github-actions · 2024-12-12T19:41:41Z

unittests/CppInterOp/DynamicLibraryManagerTest.cpp

+  return nameForDlsym;
+}
+
+#include "../../lib/Interpreter/CppInterOp.cpp"


warning: suspicious #include of file with '.cpp' extension [bugprone-suspicious-include]

#include "../../lib/Interpreter/CppInterOp.cpp" ^

unittests/CppInterOp/TestSharedLib1/TestSharedLib1.h

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 12. Check the log or trigger a new build to see more.

github-actions · 2024-12-18T19:02:30Z

lib/Interpreter/CppInterOp.cpp

+  // TODO: Test fot thread safe.
+  class AutoLoadLibrarySearchGenerator;
+  static AutoLoadLibrarySearchGenerator *sAutoSG = null;
  // Flag to indicate ownership when an external interpreter instance is used.


warning: use of undeclared identifier 'null' [clang-diagnostic-error]

static AutoLoadLibrarySearchGenerator *sAutoSG = null; ^

github-actions · 2024-12-18T19:02:30Z

lib/Interpreter/CppInterOp.cpp

                         complete_column);
  }

+#define DEBUG_TYPE "autoload"


warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays]

std::unique_ptr<char[]> content(new char[bufsize + 1]); ^

github-actions · 2024-12-18T19:02:31Z

lib/Interpreter/CppInterOp.cpp

                         complete_column);
  }

+#define DEBUG_TYPE "autoload"


warning: no header providing "std::unique_ptr" is directly included [misc-include-cleaner]

std::unique_ptr<char[]> content(new char[bufsize + 1]); ^

github-actions · 2024-12-18T19:02:31Z

lib/Interpreter/CppInterOp.cpp

+#define DEBUG_TYPE "autoload"
+
+  static inline std::string DemangleNameForDlsym(const std::string& name) {
+    std::string nameForDlsym = name;


warning: no header providing "SEEK_SET" is directly included [misc-include-cleaner]

if (fseek(m_TempFile.get(), 0L, SEEK_SET) != 0) ^

github-actions · 2024-12-18T19:02:31Z

lib/Interpreter/CppInterOp.cpp

+    static bool is_demangle_active = false;
+    static bool demangle = false;
+    if (!is_demangle_active) {
+      auto& I = getInterp();


warning: no header providing "fread" is directly included [misc-include-cleaner]

fread(content.get(), sizeof(char), bufsize, m_TempFile.get()); ^

github-actions · 2024-12-18T19:02:31Z

lib/Interpreter/CppInterOp.cpp

+    static bool demangle = false;
+    if (!is_demangle_active) {
+      auto& I = getInterp();
+      llvm::orc::LLJIT& EE = *compat::getExecutionEngine(I);


warning: no header providing "ferror" is directly included [misc-include-cleaner]

if (ferror(m_TempFile.get()) != 0) ^

github-actions · 2024-12-18T19:02:31Z

lib/Interpreter/CppInterOp.cpp

+    if (!is_demangle_active) {
+      auto& I = getInterp();
+      llvm::orc::LLJIT& EE = *compat::getExecutionEngine(I);
+      auto t = EE.getTargetTriple();


warning: no header providing "fputs" is directly included [misc-include-cleaner]

fputs("Error reading file", stderr); ^

github-actions · 2024-12-18T19:02:31Z

lib/Interpreter/CppInterOp.cpp

+          if (!addr && !loadedLibrary) {
+            // Try to load the library which should provide the symbol definition.
+            if (DLM->loadLibrary(lib, false) != DynamicLibraryManager::LoadLibResult::kLoadLibSuccess) {
+              LLVM_DEBUG(dbgs() << "MU: Failed to load library " << lib);


warning: method 'isEnabled' can be made const [readability-make-member-function-const]

Suggested change

LLVM_DEBUG(dbgs() << "MU: Failed to load library " << lib);

bool isEnabled() const {

github-actions · 2024-12-18T19:02:31Z

lib/Interpreter/CppInterOp.cpp

+          if (addr) {
+            loadedSymbols[symbol] =
+              llvm::orc::ExecutorSymbolDef(llvm::orc::ExecutorAddr::fromPtr(addr), JITSymbolFlags::Exported);
+          } else {


warning: function 'getName' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

} else {

[[nodiscard]] StringRef getName() const override {

github-actions · 2024-12-18T19:02:31Z

lib/Interpreter/CppInterOp.cpp

+	//I.getAddressOfGlobal(*Name);
+      }
+
+      for (auto &&KV : found) {


warning: no header providing "llvm::cantFail" is directly included [misc-include-cleaner]

llvm::cantFail(R->notifyResolved(loadedSymbols)); ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-12-18T23:11:02Z

lib/Interpreter/CppInterOp.cpp

+    static bool is_demangle_active = false;
+    static bool demangle = false;
+    if (!is_demangle_active) {
+      auto& I = getInterp();


warning: The 1st argument to 'fread' is a buffer with size 0 but should be a buffer with size equal to or greater than the value of the 2nd argument (which is 1) times the 3rd argument (which is 18446744073709551615) [clang-analyzer-unix.StdCLibraryFunctions]

fread(content.get(), sizeof(char), bufsize, m_TempFile.get()); ^

Additional context

lib/Interpreter/CppInterOp.cpp:3475: Calling 'StreamCaptureInfo::GetCapturedString'

std::string result = SCI.GetCapturedString(); ^

lib/Interpreter/CppInterOp.cpp:3430: Assuming the condition is false

if (dup2(m_DupFD, m_FD) < 0) ^

lib/Interpreter/CppInterOp.cpp:3430: Taking false branch

if (dup2(m_DupFD, m_FD) < 0) ^

lib/Interpreter/CppInterOp.cpp:3433: Assuming the condition is false

if (fseek(m_TempFile.get(), 0L, SEEK_END) != 0) ^

lib/Interpreter/CppInterOp.cpp:3433: Taking false branch

if (fseek(m_TempFile.get(), 0L, SEEK_END) != 0) ^

lib/Interpreter/CppInterOp.cpp:3437: 'bufsize' initialized here

long bufsize = ftell(m_TempFile.get()); ^

lib/Interpreter/CppInterOp.cpp:3438: Assuming the condition is true

if (bufsize == -1) ^

lib/Interpreter/CppInterOp.cpp:3438: Taking true branch

if (bufsize == -1) ^

lib/Interpreter/CppInterOp.cpp:3442: Storing uninitialized value

std::unique_ptr<char[]> content(new char[bufsize + 1]); ^

lib/Interpreter/CppInterOp.cpp:3442: Passing value via 1st parameter '__p'

std::unique_ptr<char[]> content(new char[bufsize + 1]); ^

lib/Interpreter/CppInterOp.cpp:3442: Calling constructor for 'unique_ptr<char[], std::default_delete<char[]>>'

std::unique_ptr<char[]> content(new char[bufsize + 1]); ^

/usr/include/c++/13/bits/unique_ptr.h:603: Calling constructor for '__uniq_ptr_data<char, std::default_delete<char[]>, true, true>'

: _M_t(__p) ^

/usr/include/c++/13/bits/unique_ptr.h:603: Passing '' via 1st parameter '__p'

: _M_t(__p) ^

/usr/include/c++/13/bits/unique_ptr.h:603: Calling constructor for '__uniq_ptr_impl<char, std::default_delete<char[]>>'

: _M_t(__p) ^

/usr/include/c++/13/bits/unique_ptr.h:175: Calling '__uniq_ptr_impl::_M_ptr'

__uniq_ptr_impl(pointer __p) : _M_t() { _M_ptr() = __p; } ^

/usr/include/c++/13/bits/unique_ptr.h:196: Calling 'get<0UL, char *, std::default_delete<char[]>>'

pointer& _M_ptr() noexcept { return std::get<0>(_M_t); } ^

/usr/include/c++/13/tuple:1803: Calling '__get_helper<0UL, char *, std::default_delete<char[]>>'

{ return std::__get_helper<__i>(__t); } ^

/usr/include/c++/13/tuple:1787: Calling '_Tuple_impl::_M_head'

{ return _Tuple_impl<__i, _Head, _Tail...>::_M_head(__t); } ^

/usr/include/c++/13/tuple:268: Calling '_Head_base::_M_head'

_M_head(_Tuple_impl& __t) noexcept { return _Base::_M_head(__t); } ^

/usr/include/c++/13/tuple:268: Returning from '_Head_base::_M_head'

_M_head(_Tuple_impl& __t) noexcept { return _Base::_M_head(__t); } ^

/usr/include/c++/13/tuple:1787: Returning from '_Tuple_impl::_M_head'

{ return _Tuple_impl<__i, _Head, _Tail...>::_M_head(__t); } ^

/usr/include/c++/13/tuple:1803: Returning from '__get_helper<0UL, char *, std::default_delete<char[]>>'

{ return std::__get_helper<__i>(__t); } ^

/usr/include/c++/13/bits/unique_ptr.h:196: Returning from 'get<0UL, char *, std::default_delete<char[]>>'

pointer& _M_ptr() noexcept { return std::get<0>(_M_t); } ^

/usr/include/c++/13/bits/unique_ptr.h:175: Returning from '__uniq_ptr_impl::_M_ptr'

__uniq_ptr_impl(pointer __p) : _M_t() { _M_ptr() = __p; } ^

/usr/include/c++/13/bits/unique_ptr.h:175: The value of '__p' is assigned to 'content._M_t._M_t._M_head_impl'

__uniq_ptr_impl(pointer __p) : _M_t() { _M_ptr() = __p; } ^

/usr/include/c++/13/bits/unique_ptr.h:603: Returning from constructor for '__uniq_ptr_impl<char, std::default_delete<char[]>>'

: _M_t(__p) ^

/usr/include/c++/13/bits/unique_ptr.h:603: Returning from constructor for '__uniq_ptr_data<char, std::default_delete<char[]>, true, true>'

: _M_t(__p) ^

lib/Interpreter/CppInterOp.cpp:3442: Returning from constructor for 'unique_ptr<char[], std::default_delete<char[]>>'

std::unique_ptr<char[]> content(new char[bufsize + 1]); ^

lib/Interpreter/CppInterOp.cpp:3445: Assuming the condition is false

if (fseek(m_TempFile.get(), 0L, SEEK_SET) != 0) ^

lib/Interpreter/CppInterOp.cpp:3445: Taking false branch

if (fseek(m_TempFile.get(), 0L, SEEK_SET) != 0) ^

lib/Interpreter/CppInterOp.cpp:3450: The 1st argument to 'fread' is a buffer with size 0 but should be a buffer with size equal to or greater than the value of the 2nd argument (which is 1) times the 3rd argument (which is 18446744073709551615)

fread(content.get(), sizeof(char), bufsize, m_TempFile.get()); ^

github-actions · 2024-12-18T23:11:02Z

lib/Interpreter/CppInterOp.cpp

+    }
+    sAutoSG->setEnabled(autoload);
+
+    LLVM_DEBUG(dbgs() << "Autoload=" << (sAutoSG->isEnabled() ? "ON" : "OFF"));


warning: no header providing "std::unordered_map" is directly included [misc-include-cleaner]

lib/Interpreter/CppInterOp.cpp:26:

- #if CLANG_VERSION_MAJOR >= 19 + #include <unordered_map> + #if CLANG_VERSION_MAJOR >= 19

github-actions · 2024-12-18T23:11:02Z

unittests/CppInterOp/TestSharedLib2/TestSharedLib2.h

@@ -0,0 +1,13 @@
+#ifndef UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB2_H
+#define UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB2_H


warning: header guard does not follow preferred style [llvm-header-guard]

Suggested change

#define UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB2_H

#ifndef GITHUB_WORKSPACE_UNITTESTS_CPPINTEROP_TESTSHAREDLIB2_TESTSHAREDLIB2_H

#define GITHUB_WORKSPACE_UNITTESTS_CPPINTEROP_TESTSHAREDLIB2_TESTSHAREDLIB2_H

unittests/CppInterOp/TestSharedLib2/TestSharedLib2.h:12:

- #endif // UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB2_H + #endif // GITHUB_WORKSPACE_UNITTESTS_CPPINTEROP_TESTSHAREDLIB2_TESTSHAREDLIB2_H

github-actions

clang-tidy made some suggestions

github-actions · 2025-01-11T17:08:42Z

lib/Interpreter/CppInterOp.cpp

+  // Last assigned Autoload SearchGenerator
+  // TODO: Test fot thread safe.
+  class AutoLoadLibrarySearchGenerator;
+  static AutoLoadLibrarySearchGenerator *sAutoSG = nullptr;


warning: variable 'sAutoSG' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

static AutoLoadLibrarySearchGenerator *sAutoSG = nullptr; ^

github-actions · 2025-01-11T17:08:43Z

lib/Interpreter/CppInterOp.cpp

+  // Last assigned Autoload SearchGenerator
+  // TODO: Test fot thread safe.
+  class AutoLoadLibrarySearchGenerator;
+  static AutoLoadLibrarySearchGenerator *sAutoSG = nullptr;


warning: variable 'sAutoSG' provides global access to a non-const object; consider making the pointed-to data 'const' [cppcoreguidelines-avoid-non-const-global-variables]

static AutoLoadLibrarySearchGenerator *sAutoSG = nullptr; ^

github-actions

clang-tidy made some suggestions

github-actions · 2025-01-12T07:48:10Z

lib/Interpreter/CppInterOp.cpp

+        if (!loadedSymbols.empty()) {
+          llvm::cantFail(R->notifyResolved(loadedSymbols));
+
+          llvm::orc::SymbolDependenceGroup DepGroup;


warning: no type named 'SymbolDependenceGroup' in namespace 'llvm::orc'; did you mean 'SymbolDependenceMap'? [clang-diagnostic-error]

Suggested change

llvm::orc::SymbolDependenceGroup DepGroup;

llvm::orc::SymbolDependenceMap DepGroup;

Additional context

llvm/include/llvm/ExecutionEngine/Orc/Core.h:125: 'SymbolDependenceMap' declared here

using SymbolDependenceMap = DenseMap<JITDylib *, SymbolNameSet>; ^

github-actions · 2025-01-12T07:48:10Z

lib/Interpreter/CppInterOp.cpp

+          llvm::cantFail(R->notifyResolved(loadedSymbols));
+
+          llvm::orc::SymbolDependenceGroup DepGroup;
+          llvm::cantFail(R->notifyEmitted({DepGroup}));


warning: too many arguments to function call, expected 0, have 1 [clang-diagnostic-error]

llvm::cantFail(R->notifyEmitted({DepGroup})); ^

Additional context

llvm/include/llvm/ExecutionEngine/Orc/Core.h:1932: 'notifyEmitted' declared here

inline Error MaterializationResponsibility::notifyEmitted() { ^

github-actions

clang-tidy made some suggestions

github-actions · 2025-01-12T08:20:31Z

lib/Interpreter/CppInterOp.cpp

+#include "llvm/ExecutionEngine/Orc/Core.h"
 #include "llvm/Support/Casting.h"
+#include "llvm/Support/Error.h"
 #include "llvm/Support/Debug.h"


warning: #includes are not sorted properly [llvm-include-order]

Suggested change

#include "llvm/Support/Debug.h"

#include "llvm/Support/Debug.h"

#include "llvm/Support/Error.h"

anutosh491 · 2025-01-24T08:45:40Z

Hey @alexander-penev

What is the progress on this ?

I haven't had the time to looking into the library loading feature yet but we would need this for xeus-cpp-lite and xeus-cpp I suppose. My understanding was that this would supersede the Loading shared objects feature we could achieve with cling's pragma.

Co-authored-by: Vassil Vassilev <[email protected]>

github-actions

clang-tidy made some suggestions

github-actions · 2025-01-31T10:50:52Z

lib/Interpreter/CppInterOp.cpp

+      llvm::orc::SymbolNameVector fSymbols;
+    public:
+      AutoloadLibraryMU(const std::string &Library, const llvm::orc::SymbolNameVector &Symbols)
+        : MaterializationUnit({getSymbolFlagsMap(Symbols), nullptr}), fLibrary(Library), fSymbols(Symbols) {}


warning: pass by value and use std::move [modernize-pass-by-value]

Suggested change

: MaterializationUnit({getSymbolFlagsMap(Symbols), nullptr}), fLibrary(Library), fSymbols(Symbols) {}

AutoloadLibraryMU(std::string Library, const llvm::orc::SymbolNameVector &Symbols)

: MaterializationUnit({getSymbolFlagsMap(Symbols), nullptr}), fLibrary(std::move(Library)), fSymbols(Symbols) {}

github-actions bot reviewed Jul 10, 2024

View reviewed changes

github-actions bot reviewed Jul 11, 2024

View reviewed changes

lib/Interpreter/CppInterOp.cpp Outdated Show resolved Hide resolved

github-actions bot reviewed Jul 28, 2024

View reviewed changes

vgvassilev reviewed Jul 28, 2024

View reviewed changes

github-actions bot reviewed Jul 30, 2024

View reviewed changes

github-actions bot reviewed Jul 31, 2024

View reviewed changes

github-actions bot reviewed Sep 6, 2024

View reviewed changes

lib/Interpreter/CppInterOp.cpp Show resolved Hide resolved

lib/Interpreter/CppInterOp.cpp Show resolved Hide resolved

lib/Interpreter/CppInterOp.cpp Show resolved Hide resolved

alexander-penev force-pushed the AddLibraryLoader branch from 0686324 to c1dd45f Compare September 19, 2024 10:53

github-actions bot reviewed Sep 19, 2024

View reviewed changes

alexander-penev force-pushed the AddLibraryLoader branch from c1dd45f to a04706e Compare September 19, 2024 11:12

mcbarton force-pushed the AddLibraryLoader branch from a04706e to 876169a Compare October 27, 2024 16:59

alexander-penev force-pushed the AddLibraryLoader branch from af9fdf8 to 876169a Compare December 12, 2024 17:46

alexander-penev requested a review from vgvassilev December 12, 2024 17:48

alexander-penev force-pushed the AddLibraryLoader branch 2 times, most recently from a7ebf63 to 307574f Compare December 12, 2024 19:35

github-actions bot reviewed Dec 12, 2024

View reviewed changes

github-actions bot reviewed Dec 18, 2024

View reviewed changes

alexander-penev force-pushed the AddLibraryLoader branch from 7383818 to 95e531f Compare January 11, 2025 17:02

github-actions bot reviewed Jan 11, 2025

View reviewed changes

github-actions bot reviewed Jan 12, 2025

View reviewed changes

alexander-penev and others added 23 commits January 30, 2025 18:31

Library autoloader

a4242e9

Fix some clang-tidy suggested issues

aae272b

Fix some clang-tidy suggested issues 2

1cbc857

Fix

ae4b0ab

Update CppInterOp.cpp

f55485a

Fix demangle

4af7185

Apply suggestions from code review

38066ab

Co-authored-by: Vassil Vassilev <[email protected]>

Update DynamicLibraryManagerSymbol.cpp

7240434

Update DynamicLibraryManagerSymbol.cpp

f815bac

Update DynamicLibraryManagerTest.cpp

a8f441d

Update CMakeLists.txt

b5eb022

Fix demangle build

80c76c1

Cleanup

1f5111e

Restore sAutoSG in CppInterOp.cpp

2ab35af

Fix null -> nullptr in CppInterOp.cpp

b307433

Fix ExecutorSymbolDef compat in llvm<17

a369962

Fix compat in llvm<17

ea75cb4

Fix compat in llvm<17 (2)

90e9c85

Fix compat in llvm<17 (3)

3e7e87e

Fix compat in llvm<17 (4)

bbcb9f0

Fix compat in llvm<17 (5)

c280c70

Fix compat in llvm<17 (6)

c4c646f

Fix

6ef47d7

alexander-penev force-pushed the AddLibraryLoader branch from 06effa9 to 6ef47d7 Compare January 31, 2025 10:45

github-actions bot reviewed Jan 31, 2025

View reviewed changes

alexander-penev added 2 commits January 31, 2025 14:54

Fix1

2cb8352

Fix3

03a8e0b

mcbarton mentioned this pull request Apr 2, 2025

Frame tests for loading shared objects for the emscripten build #548

Merged

4 tasks

	if (!sAutoSG \|\| !sAutoSG->isEnabled()) {
	[[nodiscard]] StringRef getName() const override {

	StringRef getName() const override {
	[[nodiscard]] StringRef getName() const override {



		#include "llvm/ExecutionEngine/Orc/Core.h"
		#include "llvm/ExecutionEngine/Orc/DebugUtils.h"

	#include "llvm/Support/FileSystem.h"
	#include "llvm/Support/FileSystem.h"

	LLVM_DEBUG(dbgs() << "MU: Failed to load library " << lib);
	bool isEnabled() const {

		@@ -0,0 +1,13 @@
		#ifndef UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB2_H
		#define UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB2_H

	#define UNITTESTS_CPPINTEROP_TESTSHAREDLIB_TESTSHAREDLIB2_H
	#ifndef GITHUB_WORKSPACE_UNITTESTS_CPPINTEROP_TESTSHAREDLIB2_TESTSHAREDLIB2_H
	#define GITHUB_WORKSPACE_UNITTESTS_CPPINTEROP_TESTSHAREDLIB2_TESTSHAREDLIB2_H

	llvm::orc::SymbolDependenceGroup DepGroup;
	llvm::orc::SymbolDependenceMap DepGroup;

	#include "llvm/Support/Debug.h"
	#include "llvm/Support/Debug.h"
	#include "llvm/Support/Error.h"

	: MaterializationUnit({getSymbolFlagsMap(Symbols), nullptr}), fLibrary(Library), fSymbols(Symbols) {}
	AutoloadLibraryMU(std::string Library, const llvm::orc::SymbolNameVector &Symbols)
	: MaterializationUnit({getSymbolFlagsMap(Symbols), nullptr}), fLibrary(std::move(Library)), fSymbols(Symbols) {}

Comments

Conversation

alexander-penev commented Jul 10, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 10, 2024 •

edited

Loading

aaronj0 commented Sep 20, 2024 •

edited

Loading