Upgrade CppInterOp to support llvm 20 (non-wasm) #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
=======================================
Coverage 71.17% 71.17%
=======================================
Files 9 9
Lines 3552 3552
=======================================
Hits 2528 2528
Misses 1024 1024
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -174,13 +174,15 @@ void CopyIncludePaths(const clang::HeaderSearchOptions& Opts, | |||
| if (!withSystem) continue; | |||
| if (withFlags) incpaths.push_back("-isystem"); | |||
| break; | |||
|
|
|||
| //option doesn't appear to exist for llvm>19. Will revert if I determine otherwise. | |||
| #if CLANG_VERSION_MAJOR < 20 | |||
There was a problem hiding this comment.
warning: no header providing "CLANG_VERSION_MAJOR" is directly included [misc-include-cleaner]
lib/Interpreter/Paths.cpp:20:
+ #include <clang/Basic/Version.h>
mcbarton
force-pushed
the
Update-to-llvm-20
branch
4 times, most recently
from
c8a5a4d to
e435205
Compare
mcbarton
force-pushed
the
Update-to-llvm-20
branch
from
e435205 to
391be18
Compare
mcbarton
force-pushed
the
Update-to-llvm-20
branch
from
f04cc0f to
699c6d7
Compare
mcbarton
changed the title
|
I get these warnings while building latest llvm Possibly should be fixed in our llvm build too ! |
Thanks. Will look into this. Need to see if this option is avilable on older versions of llvm, given the ci covers multiple versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
Given the llvm 20.x branch got released today I can begin the upgrade to CppInterOp to support llvm 20.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist