Use target_link_options instead of set_target_properties for linking

[anutosh491]

Description

CppInterOp used to use target_link_options before #483 went in. Not sure why this change was made. set_target_properties comes under the old style cmake and target_link_options and target_compile_options falls under mordern cmake which cmake promotes to be used with target_link_libraries.

This PR reverts back to what we were originally using. add_llvm_library internally make use of target_link_libraries and we should use target_link_options that goes with it .

Type of change

Please tick all options which are relevant.

• Bug fix
• New feature
• Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

• I have read the contribution guide recently

[anutosh491]

Was requested here #483 (comment) originally.

[mcbarton]

You should probably make the change here too https://github.com/anutosh491/CppInterOp/blob/03fe9d122a8f756befaf77d699ad720cf10af6f3/unittests/CppInterOp/TestSharedLib/CMakeLists.txt#L14 as part of this PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.71%. Comparing base (ca6055f) to head (191fc62).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #524   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files           9        9           
  Lines        3618     3618           
=======================================
  Hits         2631     2631           
  Misses        987      987           

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.