Remove unimplemented ReportInvokeEnd #526
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcbarton
force-pushed
the
Remove-unused-ReportInvokeEnd
branch
from
c60564a to
ae80091
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #526 +/- ##
=======================================
Coverage 72.71% 72.71%
=======================================
Files 9 9
Lines 3618 3618
=======================================
Hits 2631 2631
Misses 987 987
🚀 New features to boost your workflow:
|
|
Yeah maybe @aaronj0 could educate us on if this is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
I believe @anutosh491 is right about this not being implemented. This PR simply removes at the moment, but given there is a ReportInvokeStart, then it should probably be implemented. If one of the reviewers says that it needs an implementation I will look into this at some point (and modify this PR accordingly).
Fixes # (issue)
Fixes #522
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist