Fix typos in repo #556
Fix typos in repo #556
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
=======================================
Coverage 75.94% 75.94%
=======================================
Files 9 9
Lines 3646 3646
=======================================
Hits 2769 2769
Misses 877 877
🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -606,10 +606,12 @@ | |||
| Deps.push_back(Data + Dyn.d_un.d_val); | |||
| break; | |||
| case ELF::DT_RPATH: | |||
| SplitPaths(Data + Dyn.d_un.d_val, RPath, utils::kAllowNonExistant, Cpp::utils::platform::kEnvDelim, false); | |||
| SplitPaths(Data + Dyn.d_un.d_val, RPath, utils::kAllowNonExistent, | |||
There was a problem hiding this comment.
warning: do not access members of unions; use (boost::)variant instead [cppcoreguidelines-pro-type-union-access]
SplitPaths(Data + Dyn.d_un.d_val, RPath, utils::kAllowNonExistent,
^| break; | ||
| case ELF::DT_RUNPATH: | ||
| SplitPaths(Data + Dyn.d_un.d_val, RunPath, utils::kAllowNonExistant, Cpp::utils::platform::kEnvDelim, false); | ||
| SplitPaths(Data + Dyn.d_un.d_val, RunPath, utils::kAllowNonExistent, |
There was a problem hiding this comment.
warning: do not access members of unions; use (boost::)variant instead [cppcoreguidelines-pro-type-union-access]
SplitPaths(Data + Dyn.d_un.d_val, RunPath, utils::kAllowNonExistent,
^| Paths.push_back(Split.first); | ||
| else if (Verbose) | ||
| LogNonExistantDirectory(Split.first); | ||
| LogNonExistentDirectory(Split.first); |
There was a problem hiding this comment.
warning: do not use 'else' after 'return' [llvm-else-after-return]
| LogNonExistentDirectory(Split.first); | |
| } if (Mode == kAllowNonExistent) | |
| Paths.push_back(Split.first); | |
| else if (Verbose) | |
| LogNonExistentDirectory(Split.first); |
There was a problem hiding this comment.
That's probably a good warning to fix.
There was a problem hiding this comment.
I tried applying this suggestion, and it broke the ci jobs (also caused another lot of review comments). Reverted.
| } | ||
| return false; | ||
| } else if (Mode == kAllowNonExistant) | ||
| } else if (Mode == kAllowNonExistent) | ||
| Paths.push_back(Split.first); | ||
| else if (Verbose) |
There was a problem hiding this comment.
warning: do not use 'else' after 'return' [llvm-else-after-return]
| else if (Verbose) | |
| } if (Mode == kAllowNonExistent) | |
| Paths.push_back(Split.first); | |
| else if (Verbose) |
| @@ -311,10 +314,10 @@ | |||
| if (!PathStr.empty()) { | |||
There was a problem hiding this comment.
warning: expected unqualified-id [clang-diagnostic-error]
if (!PathStr.empty()) {
^| @@ -331,7 +334,7 @@ | |||
|
|
|||
| llvm::SmallVector<llvm::StringRef, 10> Paths; | |||
| if (Delim && *Delim) | |||
| SplitPaths(PathStr, Paths, kAllowNonExistant, Delim, HOpts.Verbose); | |||
| SplitPaths(PathStr, Paths, kAllowNonExistent, Delim, HOpts.Verbose); | |||
There was a problem hiding this comment.
warning: use of undeclared identifier 'kAllowNonExistent'; did you mean 'utils::kAllowNonExistent'? [clang-diagnostic-error]
| SplitPaths(PathStr, Paths, kAllowNonExistent, Delim, HOpts.Verbose); | |
| SplitPaths(PathStr, Paths, utils::kAllowNonExistent, Delim, HOpts.Verbose); |
Additional context
lib/Interpreter/Paths.h:64: 'utils::kAllowNonExistent' declared here
kAllowNonExistent ///< Add all paths whether they exist or not
^
|
@vgvassilev Is it ok for me merge this PR in, despite #556 (comment) not being done, given the objective of this PR was just to fix typos? |
Description
Please include a summary of changes, motivation and context for this PR.
There was many typos in CppInterOp including in the names of variables and functions in the code. This PR fixes these typos.
A similar PR fixing typos in xeus-cpp is here compiler-research/xeus-cpp#285
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist