[wip] Build CppInterOp as a shared library on Windows #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
lib/Interpreter/Paths.cpp
Outdated
| // | ||
| // rdar://84036149 | ||
|
|
||
| #if CLANG_VERSION_MAJOR < 20 |
There was a problem hiding this comment.
warning: no header providing "CLANG_VERSION_MAJOR" is directly included [misc-include-cleaner]
lib/Interpreter/Paths.cpp:20:
+ #include <clang/Basic/Version.h>
mcbarton
force-pushed
the
Windows-shared-library-new
branch
2 times, most recently
from
9acb6c2 to
1fe2ac4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #560 +/- ##
==========================================
- Coverage 75.94% 75.93% -0.02%
==========================================
Files 9 9
Lines 3646 3644 -2
==========================================
- Hits 2769 2767 -2
Misses 877 877 🚀 New features to boost your workflow:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
mcbarton
force-pushed
the
Windows-shared-library-new
branch
from
da8151c to
5a05154
Compare
mcbarton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
This is a duplicate of #454 , but without the random commit history, and without any conflicts with the main branch.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist