Skip to content

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Sep 25, 2025

Description

Please include a summary of changes, motivation and context for this PR.

I was looking through Emscripten forges recipe repo and noticed the pin on nlohmann json is being dropped, so this PR does the same for the main repo.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@anutosh491
Copy link
Collaborator

You also need to make the nlohmann_json_abi changes !

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.10%. Comparing base (df191a1) to head (f0b68ee).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   81.78%   82.10%   +0.31%     
==========================================
  Files          20       20              
  Lines         950      950              
  Branches       87       87              
==========================================
+ Hits          777      780       +3     
+ Misses        173      170       -3     

see 1 file with indirect coverage changes
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcbarton
Copy link
Collaborator Author

You also need to make the nlohmann_json_abi changes !

@anutosh491 Thanks for the tip. Can you point me towards the PR where this was done in Emscripten forge, and I will make the changes needed here. To me it seems that this PR was opened up straight after xeus-cpps recipe in Emscripten forge was updated to 0.7.2

@anutosh491
Copy link
Collaborator

anutosh491 commented Sep 25, 2025

Check the latest recipes on conda-forge and emscripten-forge (and use a git blame if that helps. On phone right now so won't be able to find a link)

This is not an emscripten env specific change for your information.

@mcbarton mcbarton force-pushed the Drop-pin-on-nlohmann_json branch from 210b338 to 8130444 Compare September 25, 2025 10:09
@mcbarton
Copy link
Collaborator Author

mcbarton commented Sep 25, 2025

Not sure why nlohmann_json-abi can be found when doing the build on the Github runners, but not the read the docs build. I will investigate later.

@mcbarton mcbarton force-pushed the Drop-pin-on-nlohmann_json branch from 8130444 to 5fa9d44 Compare September 25, 2025 14:14
@mcbarton mcbarton force-pushed the Drop-pin-on-nlohmann_json branch from a000e18 to f0b68ee Compare September 25, 2025 15:23
Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I'm guessing this solves the build the docs thing. Let's merge it and then you can close my previous Pr I guess ?

@vgvassilev vgvassilev merged commit 81fed93 into compiler-research:main Sep 25, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants