Skip to content

feat: buffered IO implementation #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat: buffered IO implementation #386

wants to merge 8 commits into from

Conversation

Berrysoft
Copy link
Member

@Berrysoft Berrysoft commented Mar 16, 2025 •
edited by AsakuraMizu
Loading

I have to modify the traits in compio-io to match the signature of trait TakeBuffer in compio-driver. A disadvantage is that BorrowedBuffer could not impl IoBuf.

Some other ideas that will be fixed in future PRs:

  • RecvManaged::new and ReadManagedAt::new should not return Result.
  • Adjust the parameter order of read_managed_at?

@Berrysoft Berrysoft added enhancement New feature or request package: net Related to compio-net package: fs Related to compio-fs package: io Related to compio-io package: runtime Related to compio-runtime package: process Related to compio-process labels Mar 16, 2025
@Berrysoft Berrysoft requested a review from George-Miao March 16, 2025 08:43
@Berrysoft Berrysoft self-assigned this Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@George-Miao George-Miao Awaiting requested review from George-Miao

At least 1 approving review is required to merge this pull request.

Assignees

@Berrysoft Berrysoft

Labels
enhancement New feature or request package: fs Related to compio-fs package: io Related to compio-io package: net Related to compio-net package: process Related to compio-process package: runtime Related to compio-runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Berrysoft