Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mac build] Add macros build #845

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Mac build] Add macros build #845

wants to merge 1 commit into from

Conversation

Steelskin
Copy link
Collaborator

No description provided.

@Steelskin Steelskin force-pushed the fabrice/mac-build-stdlib branch from 5a2d842 to 6ea346c Compare November 13, 2024 18:01
@Steelskin Steelskin force-pushed the fabrice/mac-build-macros branch 2 times, most recently from 747d816 to 992ea9b Compare November 13, 2024 18:05
@Steelskin Steelskin force-pushed the fabrice/mac-build-stdlib branch from 6ea346c to fb11672 Compare December 4, 2024 18:50
@Steelskin Steelskin force-pushed the fabrice/mac-build-stdlib branch 4 times, most recently from 425fe14 to 4643a5a Compare December 19, 2024 22:51
@Steelskin Steelskin force-pushed the fabrice/mac-build-stdlib branch from 4643a5a to fe272e4 Compare January 6, 2025 23:12
@Steelskin Steelskin force-pushed the fabrice/mac-build-stdlib branch 2 times, most recently from 718402d to fb2523c Compare January 15, 2025 23:09
@Steelskin Steelskin force-pushed the fabrice/mac-build-macros branch from 992ea9b to fc58a43 Compare January 16, 2025 19:48
compnerd
compnerd reviewed Jan 16, 2025
View reviewed changes
Copy link
Owner

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you can likely extract the naming changes as that is a purely mechanical change.

@Steelskin Steelskin force-pushed the fabrice/mac-build-stdlib branch 2 times, most recently from 22f85d3 to 71128d5 Compare January 27, 2025 21:01
@Steelskin Steelskin force-pushed the fabrice/mac-build-stdlib branch from 71128d5 to 116e75d Compare February 3, 2025 18:00
@Steelskin Steelskin force-pushed the fabrice/mac-build-stdlib branch 4 times, most recently from 4b3edb0 to eb90037 Compare February 25, 2025 01:12
Base automatically changed from fabrice/mac-build-stdlib to main February 26, 2025 22:41
@Steelskin Steelskin force-pushed the fabrice/mac-build-macros branch 2 times, most recently from 0852548 to 6e26d5a Compare February 28, 2025 17:54
@Steelskin Steelskin force-pushed the fabrice/mac-build-macros branch 2 times, most recently from 519271b to ff39455 Compare February 28, 2025 18:41
@Steelskin Steelskin force-pushed the fabrice/mac-build-macros branch 2 times, most recently from 3e9ba22 to d6cd038 Compare March 25, 2025 19:16
@Steelskin Steelskin marked this pull request as ready for review March 26, 2025 18:08
@Steelskin Steelskin requested a review from compnerd March 26, 2025 18:09
@Steelskin
Copy link
Collaborator Author

Steelskin commented Mar 26, 2025 •
edited
Loading

Asking for a re-review now that the build is more or less fixed. I'll run another build to confirm this does not break anything.

@Steelskin Steelskin force-pushed the fabrice/mac-build-macros branch from d6cd038 to 3d2c48c Compare March 26, 2025 18:09
@Steelskin Steelskin force-pushed the fabrice/mac-build-macros branch from 3d2c48c to 59fea04 Compare April 4, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd Awaiting requested review from compnerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Steelskin @compnerd