Skip to content

build: Use the setup-build action in swift-toolchain #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025

Conversation

Steelskin
Copy link
Collaborator

  • Use the setup-build action in every job.
  • Move the build machine setup to the beginning of the job as this saves time when it fails.
  • Remove WORKAROUND_WINDOWS_SDK_VERSION for the smoke tests, they should test the latest Windows SDK version.

@Steelskin Steelskin requested a review from compnerd June 2, 2025 18:02
@Steelskin
Copy link
Collaborator Author

I ran this build with these changes last week: https://github.com/thebrowsercompany/swift-build/actions/runs/15357521575
You can ignore the failure, it fails to set the release as expected as this was a manually triggered build.

@Steelskin Steelskin requested a review from compnerd June 9, 2025 22:05
@Steelskin
Copy link
Collaborator Author

Here's another test run with the updated paths: https://github.com/thebrowsercompany/swift-build/actions/runs/15538885807

@Steelskin Steelskin merged commit 1c4919d into main Jun 9, 2025
1 check passed
@Steelskin Steelskin deleted the fabrice/use-setup-build-action branch June 9, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants