fix: Timelock improvements and GovernorBravoDelegate ETH transfer bug#303
Open
weiwei9964 wants to merge 1 commit into
Open
fix: Timelock improvements and GovernorBravoDelegate ETH transfer bug#303weiwei9964 wants to merge 1 commit into
weiwei9964 wants to merge 1 commit into
Conversation
Closes compound-finance#214 and compound-finance#150 compound-finance#214: Timelock improvements - Remove SafeMath import (Sol 0.8+ has built-in overflow checks) - Remove public from constructor - Add in-queue check for cancelTransaction() compound-finance#150: Fix ETH locked in Timelock - Change executeTransaction value from proposal.values[i] to 0 - ETH should come from Timelock balance, not msg.sender
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #214 — Timelock improvements
publicfrom constructorcancelTransaction()— reverts if tx not queuedFixes #150 — ETH sent to Timelock locked
executeTransaction{value: proposal.values[i]}to{value: 0}This contribution was made through an AI agent. USDC on Polygon accepted at
0xadb9291432805c27dca53db06d97afb3f2fa2658.