Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meson: use finalize method #25319

Merged
merged 7 commits into from
Sep 23, 2024
Merged

meson: use finalize method #25319

merged 7 commits into from
Sep 23, 2024

Conversation

AbrilRBS
Copy link
Member

Summary

Changes to recipe: meson/[*]

Motivation

This allows local mesons to create bytecode in the cache, without compromising its integrity, by transparently having the dependencies use a copy of the package folder in which the PYTHONDONTWRITEBYTECODE var has been disabled for Conan>=2.7. For older versions, the finalize() method has no effect and the old package folder is used

Details

See here for finalize() docs, and read this blog post for examples on its usage

@AbrilRBS AbrilRBS requested a review from perseoGI September 19, 2024 07:12
@AbrilRBS AbrilRBS self-assigned this Sep 19, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries uilianries mentioned this pull request Sep 19, 2024
Merged
3 tasks
@AbrilRBS AbrilRBS requested a review from memsharded September 20, 2024 23:45
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (83d975a7792ebf40252805570e759635a90abbcb):

  • meson/1.4.1:
    Built 5 packages out of 11 (All logs)

  • meson/1.5.0:
    Built 5 packages out of 11 (All logs)

  • meson/1.3.0:
    Built 5 packages out of 11 (All logs)

  • meson/1.5.1:
    Built 5 packages out of 11 (All logs)

  • meson/1.2.3:
    Built 5 packages out of 11 (All logs)

  • meson/1.3.1:
    Built 5 packages out of 11 (All logs)

  • meson/0.61.2:
    Built 5 packages out of 11 (All logs)

  • meson/1.3.2:
    Built 5 packages out of 11 (All logs)

  • meson/1.1.0:
    Built 5 packages out of 11 (All logs)

  • meson/1.2.2:
    Built 5 packages out of 11 (All logs)

  • meson/1.4.0:
    Built 5 packages out of 11 (All logs)

  • meson/1.1.1:
    Built 5 packages out of 11 (All logs)

  • meson/1.2.1:
    Built 5 packages out of 11 (All logs)

  • meson/1.2.0:
    Built 5 packages out of 11 (All logs)

  • meson/1.0.0:
    Built 5 packages out of 11 (All logs)

  • meson/0.59.3:
    Built 5 packages out of 11 (All logs)

  • meson/0.62.2:
    Built 5 packages out of 11 (All logs)

@conan-center-bot conan-center-bot merged commit f31a6fb into conan-io:master Sep 23, 2024
73 checks passed
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
@AbrilRBS @perseoGI @OMGtechy
(conan-io#25319) meson: use finalize method
12070e0 
* First steps for finalize() support in Meson

---------

Co-authored-by: PerseoGI <[email protected]>

* Modify wrapper in finalize to support old versions cleanly

* Discard changes to recipes/jwt-cpp/all/test_package/traits/defaults.h

* Discard changes to recipes/jwt-cpp/all/test_package/traits/traits.h

* Cealnup

---------

Co-authored-by: PerseoGI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@memsharded memsharded memsharded approved these changes

@perseoGI perseoGI Awaiting requested review from perseoGI

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AbrilRBS @conan-center-bot @uilianries @memsharded